All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: dwc: remove 'out of memory' message
@ 2017-02-25 11:03 Mihai Burduselu
  2017-02-26  8:03 ` Takashi Sakamoto
  0 siblings, 1 reply; 6+ messages in thread
From: Mihai Burduselu @ 2017-02-25 11:03 UTC (permalink / raw)
  To: tiwai, perex
  Cc: lgirdwood, broonie, Jose.Abreu, s.nawrocki, colin.king,
	michelcatalin, alsa-devel, linux-kernel

Reported by checkpatch.pl
Signed-off-by: Mihai Burduselu <michelcatalin@gmail.com>
---
 sound/soc/dwc/designware_i2s.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
index 9c46e4112026..6479768cc6a1 100644
--- a/sound/soc/dwc/designware_i2s.c
+++ b/sound/soc/dwc/designware_i2s.c
@@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
 	const char *clk_id;
 
 	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
-	if (!dev) {
-		dev_warn(&pdev->dev, "kzalloc fail\n");
+	if (!dev)
 		return -ENOMEM;
-	}
 
 	dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL);
 	if (!dw_i2s_dai)
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: dwc: remove 'out of memory' message
  2017-02-25 11:03 [PATCH] ASoC: dwc: remove 'out of memory' message Mihai Burduselu
@ 2017-02-26  8:03 ` Takashi Sakamoto
  2017-02-28 15:19     ` Takashi Iwai
  0 siblings, 1 reply; 6+ messages in thread
From: Takashi Sakamoto @ 2017-02-26  8:03 UTC (permalink / raw)
  To: Mihai Burduselu, tiwai, perex
  Cc: Jose.Abreu, alsa-devel, lgirdwood, linux-kernel, broonie,
	s.nawrocki, colin.king

Hi,

On Feb 25 2017 20:03, Mihai Burduselu wrote:
> Reported by checkpatch.pl
> Signed-off-by: Mihai Burduselu <michelcatalin@gmail.com>
> ---
>  sound/soc/dwc/designware_i2s.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> index 9c46e4112026..6479768cc6a1 100644
> --- a/sound/soc/dwc/designware_i2s.c
> +++ b/sound/soc/dwc/designware_i2s.c
> @@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
>  	const char *clk_id;
>
>  	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
> -	if (!dev) {
> -		dev_warn(&pdev->dev, "kzalloc fail\n");
> +	if (!dev)

The line for 'dev_warn()' should be kept.

>  		return -ENOMEM;
> -	}
>
>  	dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL);
>  	if (!dw_i2s_dai)


Regards

Takashi Sakamoto

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: dwc: remove 'out of memory' message
  2017-02-26  8:03 ` Takashi Sakamoto
@ 2017-02-28 15:19     ` Takashi Iwai
  0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2017-02-28 15:19 UTC (permalink / raw)
  To: Takashi Sakamoto
  Cc: Mihai Burduselu, perex, alsa-devel, colin.king, lgirdwood,
	broonie, s.nawrocki, Jose.Abreu, linux-kernel

On Sun, 26 Feb 2017 09:03:22 +0100,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Feb 25 2017 20:03, Mihai Burduselu wrote:
> > Reported by checkpatch.pl
> > Signed-off-by: Mihai Burduselu <michelcatalin@gmail.com>
> > ---
> >  sound/soc/dwc/designware_i2s.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> > index 9c46e4112026..6479768cc6a1 100644
> > --- a/sound/soc/dwc/designware_i2s.c
> > +++ b/sound/soc/dwc/designware_i2s.c
> > @@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
> >  	const char *clk_id;
> >
> >  	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
> > -	if (!dev) {
> > -		dev_warn(&pdev->dev, "kzalloc fail\n");
> > +	if (!dev)
> 
> The line for 'dev_warn()' should be kept.

In general, people regard it superfluous since kmalloc() itself
already gives a kernel warning at an allocation error.  So removing
the message is OK in that sense.

However, the problem of this (and lots of other) patch is that it
doesn't give proper information.  Instead, in a single line, it merely
declares checkpatch.pl as a bible.  Very helpful, eh?

So, please reconsider the changelog when you submit this kind of
patches.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: dwc: remove 'out of memory' message
@ 2017-02-28 15:19     ` Takashi Iwai
  0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2017-02-28 15:19 UTC (permalink / raw)
  To: Takashi Sakamoto
  Cc: Jose.Abreu, alsa-devel, linux-kernel, lgirdwood, broonie,
	s.nawrocki, colin.king, Mihai Burduselu

On Sun, 26 Feb 2017 09:03:22 +0100,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Feb 25 2017 20:03, Mihai Burduselu wrote:
> > Reported by checkpatch.pl
> > Signed-off-by: Mihai Burduselu <michelcatalin@gmail.com>
> > ---
> >  sound/soc/dwc/designware_i2s.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> > index 9c46e4112026..6479768cc6a1 100644
> > --- a/sound/soc/dwc/designware_i2s.c
> > +++ b/sound/soc/dwc/designware_i2s.c
> > @@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
> >  	const char *clk_id;
> >
> >  	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
> > -	if (!dev) {
> > -		dev_warn(&pdev->dev, "kzalloc fail\n");
> > +	if (!dev)
> 
> The line for 'dev_warn()' should be kept.

In general, people regard it superfluous since kmalloc() itself
already gives a kernel warning at an allocation error.  So removing
the message is OK in that sense.

However, the problem of this (and lots of other) patch is that it
doesn't give proper information.  Instead, in a single line, it merely
declares checkpatch.pl as a bible.  Very helpful, eh?

So, please reconsider the changelog when you submit this kind of
patches.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: dwc: remove 'out of memory' message
  2017-02-28 15:19     ` Takashi Iwai
@ 2017-03-07 12:56       ` Mark Brown
  -1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2017-03-07 12:56 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Takashi Sakamoto, Mihai Burduselu, perex, alsa-devel, colin.king,
	lgirdwood, s.nawrocki, Jose.Abreu, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

On Tue, Feb 28, 2017 at 04:19:41PM +0100, Takashi Iwai wrote:

> However, the problem of this (and lots of other) patch is that it
> doesn't give proper information.  Instead, in a single line, it merely
> declares checkpatch.pl as a bible.  Very helpful, eh?

> So, please reconsider the changelog when you submit this kind of
> patches.

Yeah, it's a *huge* set of patches with poor changelogs and very minor
benefits which is more work to digest than it seems useful to.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: dwc: remove 'out of memory' message
@ 2017-03-07 12:56       ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2017-03-07 12:56 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Jose.Abreu, alsa-devel, linux-kernel, lgirdwood, s.nawrocki,
	colin.king, Mihai Burduselu, Takashi Sakamoto


[-- Attachment #1.1: Type: text/plain, Size: 474 bytes --]

On Tue, Feb 28, 2017 at 04:19:41PM +0100, Takashi Iwai wrote:

> However, the problem of this (and lots of other) patch is that it
> doesn't give proper information.  Instead, in a single line, it merely
> declares checkpatch.pl as a bible.  Very helpful, eh?

> So, please reconsider the changelog when you submit this kind of
> patches.

Yeah, it's a *huge* set of patches with poor changelogs and very minor
benefits which is more work to digest than it seems useful to.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-03-07 21:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-25 11:03 [PATCH] ASoC: dwc: remove 'out of memory' message Mihai Burduselu
2017-02-26  8:03 ` Takashi Sakamoto
2017-02-28 15:19   ` Takashi Iwai
2017-02-28 15:19     ` Takashi Iwai
2017-03-07 12:56     ` Mark Brown
2017-03-07 12:56       ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.