From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933015AbdCGQjS (ORCPT ); Tue, 7 Mar 2017 11:39:18 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44714 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755743AbdCGQi2 (ORCPT ); Tue, 7 Mar 2017 11:38:28 -0500 Date: Tue, 7 Mar 2017 19:59:53 +0530 From: "Naveen N. Rao" To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, Steven Rostedt , Arnaldo Carvalho de Melo , linuxppc-dev@lists.ozlabs.org, Ingo Molnar Subject: Re: [PATCH 5/6] perf: probes: move ftrace README parsing logic into trace-event-parse.c References: <20170307150332.5ecac6a63a6c1d27247cbcb4@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170307150332.5ecac6a63a6c1d27247cbcb4@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17030714-0032-0000-0000-000001F5833B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17030714-0033-0000-0000-00001228D415 Message-Id: <20170307142953.GB11046@naverao1-tp.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-07_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703070121 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/03/07 03:03PM, Masami Hiramatsu wrote: > On Tue, 7 Mar 2017 16:17:40 +0530 > "Naveen N. Rao" wrote: > > > probe-file.c needs libelf, but scanning ftrace README does not require > > that. As such, move the ftrace README scanning logic out of probe-file.c > > and into trace-event-parse.c. > > Hmm, it seems probe-file.c doesn't require libelf at all... > I would like to keep ftrace related things in probe-file.c. Not sure I understand. probe-file.h explicitly calls out a need for libelf due to the probe cache and related routines - commit 40218daea1db1 ("perf list: Show SDT and pre-cached events"). However, if you prefer to retain the ftrace README scanning here, we can drop this patch and I can update patch 6 to check for libelf. Thanks, Naveen