From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755864AbdCGQm1 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Mar 2017 11:42:27 -0500
Received: from mail.kernel.org ([198.145.29.136]:57896 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755326AbdCGQmS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Mar 2017 11:42:18 -0500
Date: Tue, 7 Mar 2017 12:24:38 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        kernel-team@lge.com
Subject: Re: [PATCH 01/23] perf report: Hide tip message when -q option is
 given
Message-ID: <20170307152438.GA7670@kernel.org>
References: <20170307150851.22304-1-namhyung@kernel.org>
 <20170307150851.22304-2-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170307150851.22304-2-namhyung@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Wed, Mar 08, 2017 at 12:08:29AM +0900, Namhyung Kim escreveu:
> The tip message at the end was printed regardless of the -q option.
> Originally, the message suggested only '-s comm,dso' option for higher
> level view when no sort option and parent option were given.  Now it
> shows random help message regardless of the options so the condition can
> be simplified to honor the -q option.
> 

Applied, with this:

Before:

  $ perf report --stdio -q
    42.77%  ls       ls                [.] _init
    13.21%  ls       ld-2.24.so        [.] match_symbol
    12.55%  ls       libc-2.24.so      [.] __strcoll_l
    11.94%  ls       libc-2.24.so      [.] _init


  #
  # (Tip: Show current config key-value pairs: perf config --list)
  #
  $

After:

  $ perf report --stdio -q
    42.77%  ls       ls                [.] _init
    13.21%  ls       ld-2.24.so        [.] match_symbol
    12.55%  ls       libc-2.24.so      [.] __strcoll_l
    11.94%  ls       libc-2.24.so      [.] _init


  $

We still have those two extra lines tho, food for another patch...