All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org
Subject: generic/411 clash with TEST_DIR=/mnt
Date: Tue, 7 Mar 2017 08:50:27 -0800	[thread overview]
Message-ID: <20170307165027.GA15724@birch.djwong.org> (raw)

Hi Zorro,

I noticed that generic/411 creates some sort of directory structure
involving $TEST_DIR/$seq/$$_mpA/mnt1/mnt2, then pipes the findmnt output
through _filter_test_dir.

Unfortunately, on my test system I have TEST_DIR=/mnt, so the filtering
produces this output:

QA output created by 411
------
TEST_DIR/411 SCRATCH_DEV
mpA SCRATCH_DEV
mpATEST_DIR1 SCRATCH_DEV
mpB SCRATCH_DEV
mpBTEST_DIR1 SCRATCH_DEV
mpBTEST_DIR1/TEST_DIR2 SCRATCH_DEV
mpC SCRATCH_DEV
mpCTESTDIR1 SCRATCH_DEV
======
crash test passed

Which means that the golden output comparison fails. :(

I'm not sure what's a proper fix here: changing _filter_test_dir to be
more picky about what gets sed'ed?

e.g. sed -e "s,\([[:space:]]\)$TEST_DIR,\1TEST_DIR,g/"

Or just to change the test to use directory names that are less likely to be
mistaken for TEST_* and SCRATCH_*?

--D

             reply	other threads:[~2017-03-07 20:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07 16:50 Darrick J. Wong [this message]
2017-03-08  3:50 ` generic/411 clash with TEST_DIR=/mnt Zorro Lang
2017-03-08  6:09   ` Eryu Guan
2017-03-08  6:29     ` Zorro Lang
2017-03-08 18:11     ` Darrick J. Wong
2017-03-08 18:38       ` Zorro Lang
2017-03-08  6:50   ` Amir Goldstein
2017-03-08  7:14     ` Zorro Lang
2017-03-08  8:20       ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170307165027.GA15724@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.