All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Cheah Kok Cheong <thrust73@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: comedi: comedi_fops: Change comedi_num_legacy_minors type
Date: Tue, 7 Mar 2017 20:01:38 +0100	[thread overview]
Message-ID: <20170307190137.GA6373@kroah.com> (raw)
In-Reply-To: <cd5f3e9f6320ac0063e61f0d0457e5400091390c.1488654618.git.thrust73@gmail.com>

On Sun, Mar 05, 2017 at 03:22:32AM +0800, Cheah Kok Cheong wrote:
> Change to unsigned to allow removal of negative value check in
> init section.

Why?

> Use smaller data type since the max possible value currently is 48.

Does it matter?

thanks,

greg k-h

  parent reply	other threads:[~2017-03-07 19:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-04 19:22 [PATCH 1/2] Staging: comedi: comedi_fops: Change comedi_num_legacy_minors type Cheah Kok Cheong
2017-03-04 19:22 ` [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor numbers for board device files" Cheah Kok Cheong
2017-03-08  5:54   ` Dan Carpenter
2017-03-08 10:08     ` Cheah Kok Cheong
2017-03-08 11:13       ` Ian Abbott
2017-03-08 16:59         ` Cheah Kok Cheong
2017-03-07 19:01 ` Greg KH [this message]
2017-03-08  9:38   ` [PATCH 1/2] Staging: comedi: comedi_fops: Change comedi_num_legacy_minors type Cheah Kok Cheong
2017-03-08  9:45     ` Greg KH
2017-03-08 10:16       ` Cheah Kok Cheong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170307190137.GA6373@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thrust73@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.