From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756235AbdCGUkh (ORCPT ); Tue, 7 Mar 2017 15:40:37 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:34493 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756149AbdCGUkb (ORCPT ); Tue, 7 Mar 2017 15:40:31 -0500 Date: Tue, 7 Mar 2017 22:05:45 +0200 From: Krzysztof Kozlowski To: Jaehoon Chung Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kgene@kernel.org, robh+dt@kernel.org, javier@osg.samsung.com, niyas.ahmed@samsung.com, alim.akhtar@samsung.com, pankaj.dubey@samsung.com Subject: Re: [PATCH V3] ARM: dts: exynos5440: support the phy-pcie node for pcie Message-ID: <20170307200545.oxibgmzx6wwc2fay@kozik-lap> References: <20170228070026.8725-1-jh80.chung@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170228070026.8725-1-jh80.chung@samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 04:00:26PM +0900, Jaehoon Chung wrote: > Add pcie-phy node for using phy-exynos-pcie. > > There are some modifications. > 1. Remove the configuration space values in "ranges" property. > - The getting configuration space from ranges is old way. > - Instead, It can be got from "config" > > 2. Use the reg-names as "elbi", "config". > - Can know the purpose of use with reg-names. > Thanks, applied with changes: 1. Proper subject prefix. Please pay attention to that. 2. Re-write of commit message. There were language errors, mixed up prepositions. Also a "phy-pcie node" cannot be "supported". You can add a node. You cannot support a node. The quality of commit message is important for maintainability of source code because eventually it explains the logic behind the changes in the code. Best regards, Krzysztof