From: kusumi.tomohiro@gmail.com
To: axboe@kernel.dk, fio@vger.kernel.org
Cc: Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: [PATCH 12/17] Don't set FIO_FILE_extend when create_on_open= option is set
Date: Tue, 7 Mar 2017 22:13:03 +0200 [thread overview]
Message-ID: <20170307201308.66814-13-tkusumi@tuxera.com> (raw)
In-Reply-To: <20170307201308.66814-1-tkusumi@tuxera.com>
From: Tomohiro Kusumi <tkusumi@tuxera.com>
FIO_FILE_extend gets set and later cleared only when create_on_open=
is disabled (which is default). If create_on_open=1 is set this flag
could be set for the entire runtime, but this flag is basically
designed to be enabled only during setup time.
(If there's no "Layint out IO file..." message, both FIO_FILE_extend
and need_extend probably aren't even needed, as files can be extended
at the moment when these flag/variable are set)
Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
filesetup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/filesetup.c b/filesetup.c
index fab9c5d..f42f5d8 100644
--- a/filesetup.c
+++ b/filesetup.c
@@ -966,9 +966,9 @@ int setup_files(struct thread_data *td)
if (!o->create_on_open) {
need_extend++;
extend_size += (f->io_size + f->file_offset);
+ fio_file_set_extend(f);
} else
f->real_file_size = f->io_size + f->file_offset;
- fio_file_set_extend(f);
}
}
--
2.9.3
next prev parent reply other threads:[~2017-03-07 20:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 20:12 [PATCH 00/17] kusumi.tomohiro
2017-03-07 20:12 ` [PATCH 01/17] Add runtime handlers for 97900ebf for FreeBSD/DragonFlyBSD kusumi.tomohiro
2017-03-07 20:12 ` [PATCH 02/17] HOWTO: Add platforms without fdatasync(2) kusumi.tomohiro
2017-03-07 20:12 ` [PATCH 03/17] configure: Align help messages kusumi.tomohiro
2017-03-07 20:12 ` [PATCH 04/17] Avoid irrelevant "offset extend ends" error message for chrdev kusumi.tomohiro
2017-03-07 20:12 ` [PATCH 05/17] Fix debug print format of file ->file_name kusumi.tomohiro
2017-03-07 20:12 ` [PATCH 06/17] Fixup for a minor 0 byte file size case kusumi.tomohiro
2017-03-07 20:12 ` [PATCH 07/17] Explicitly check td_trim(td) to detect open(2) flag kusumi.tomohiro
2017-03-07 20:12 ` [PATCH 08/17] Drop redundant td_rw(td) tests kusumi.tomohiro
2017-03-07 20:13 ` [PATCH 09/17] Remove unassigned fio_unused variable kusumi.tomohiro
2017-03-07 20:13 ` [PATCH 10/17] Drop fio_unused attribute from used variable kusumi.tomohiro
2017-03-07 20:13 ` [PATCH 11/17] Fix a function name typo in debug print kusumi.tomohiro
2017-03-07 20:13 ` kusumi.tomohiro [this message]
2017-03-07 20:13 ` [PATCH 13/17] Minor fixup for "Layint out IO file..." message kusumi.tomohiro
2017-03-07 20:13 ` [PATCH 14/17] HOWTO: Add some details for invalidate= kusumi.tomohiro
2017-03-07 20:13 ` [PATCH 15/17] Define struct file_name as a file local structure kusumi.tomohiro
2017-03-07 20:13 ` [PATCH 16/17] Use union for per file engine private data storage kusumi.tomohiro
2017-03-07 20:13 ` [PATCH 17/17] configure: Make Cygwin take regular configure path kusumi.tomohiro
2017-03-10 21:44 ` [PATCH 00/17] Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307201308.66814-13-tkusumi@tuxera.com \
--to=kusumi.tomohiro@gmail.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=tkusumi@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.