From: "Dmitry V. Levin" <ldv@altlinux.org>
To: David Miller <davem@davemloft.net>
Cc: Pavel Emelyanov <xemul@virtuozzo.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error
Date: Tue, 7 Mar 2017 23:28:02 +0300 [thread overview]
Message-ID: <20170307202802.GA19323@altlinux.org> (raw)
In-Reply-To: <20170307.121649.968411437349940435.davem@davemloft.net>
On Tue, Mar 07, 2017 at 12:16:49PM -0800, David Miller wrote:
> From: "Dmitry V. Levin" <ldv@altlinux.org>
> Date: Tue, 28 Feb 2017 04:39:30 +0300
>
> > Replace MAX_ADDR_LEN with its numeric value to fix the following
> > linux/packet_diag.h userspace compilation error:
> >
> > /usr/include/linux/packet_diag.h:67:17: error: 'MAX_ADDR_LEN' undeclared here (not in a function)
> > __u8 pdmc_addr[MAX_ADDR_LEN];
> >
> > This is not the first case in the UAPI where the numeric value
> > of MAX_ADDR_LEN is used, uapi/linux/if_link.h already does the same,
> > and there are no UAPI headers besides these two that use MAX_ADDR_LEN.
> >
> > The alternative fix would be to include <linux/netdevice.h> which
> > pulls in other headers and a lot of definitions with them.
> >
> > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
>
> If if_link.h includes netdevice.h properly, let's try to do the same here as well.
Sorry if my words weren't clear enough: no, if_link.h doesn't include
netdevice.h, it uses the _numeric_ value instead:
$ grep MAX_ADDR_LEN include/uapi/linux/if_link.h
__u8 mac[32]; /* MAX_ADDR_LEN */
--
ldv
next prev parent reply other threads:[~2017-03-07 20:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 1:39 [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error Dmitry V. Levin
2017-03-07 20:16 ` David Miller
2017-03-07 20:28 ` Dmitry V. Levin [this message]
2017-03-07 20:35 ` David Miller
2017-03-07 20:50 ` [PATCH] " Dmitry V. Levin
2017-03-09 21:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307202802.GA19323@altlinux.org \
--to=ldv@altlinux.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.