From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] doc: fix parameter of virtio_user for
	container
Date: Wed, 8 Mar 2017 09:36:34 +0800
Message-ID: <20170308013634.GU18844@yliu-dev.sh.intel.com>
References: <1488894525-5430-1-git-send-email-wang.yong19@zte.com.cn>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: jianfeng.tan@intel.com, dev@dpdk.org
To: Yong Wang <wang.yong19@zte.com.cn>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 00B731BBE
 for <dev@dpdk.org>; Wed,  8 Mar 2017 02:38:01 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1488894525-5430-1-git-send-email-wang.yong19@zte.com.cn>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 07, 2017 at 08:48:45AM -0500, Yong Wang wrote:
> Update the "Virtio_user for Container Networking" doc, add the
> "--file-prefix" option to testpmd in host and container to avoid
> hugepage config file conflict.
> 
> Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container
> networking")

Fixline should be one line: don't break it to two.

> 
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
>  doc/guides/howto/virtio_user_for_container_networking.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/howto/virtio_user_for_container_networking.rst b/doc/guides/howto/virtio_user_for_container_networking.rst
> index dbb9319..d08a5e3 100644
> --- a/doc/guides/howto/virtio_user_for_container_networking.rst
> +++ b/doc/guides/howto/virtio_user_for_container_networking.rst
> @@ -111,7 +111,8 @@ some minor changes.
>      .. code-block:: console
>  
>          $(testpmd) -l 0-1 -n 4 --socket-mem 1024,1024 \
> -            --vdev 'eth_vhost0,iface=/tmp/sock0' --no-pci -- -i
> +            --vdev 'eth_vhost0,iface=/tmp/sock0' \
> +            --file-prefix=host_ --no-pci -- -i

Though it's okay to add the "_", it looks a bit weird. I'd like to
remove it.

Besides that,

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>


	--yliu
>  
>  #. Start a container instance with a virtio-user port.
>  
> @@ -121,6 +122,7 @@ some minor changes.
>              -v /dev/hugepages:/dev/hugepages \
>              dpdk-app-testpmd testpmd -l 6-7 -n 4 -m 1024 --no-pci \
>              --vdev=virtio_user0,path=/var/run/usvhost \
> +            --file-prefix=container_ \
>  	    -- -i --txqflags=0xf00 --disable-hw-vlan
>  
>  Note: If we run all above setup on the host, it's a shm-based IPC.
> -- 
> 1.8.3.1
>