From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751846AbdCHIqk (ORCPT ); Wed, 8 Mar 2017 03:46:40 -0500 Received: from mail.kernel.org ([198.145.29.136]:52182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751786AbdCHIqh (ORCPT ); Wed, 8 Mar 2017 03:46:37 -0500 Date: Wed, 8 Mar 2017 09:37:07 +0100 From: Masami Hiramatsu To: Ravi Bangoria Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] perf probe: Fix concat_probe_trace_events Message-Id: <20170308093707.77fb1e3db24ce167a8aff914@kernel.org> In-Reply-To: <20170308065908.4128-1-ravi.bangoria@linux.vnet.ibm.com> References: <20170308065908.4128-1-ravi.bangoria@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Mar 2017 12:29:07 +0530 Ravi Bangoria wrote: > '*ntevs' contains number of elements present in 'tevs' array. If > there are no elements in array, 'tevs2' can be directly assigned > to 'tevs' without allocating more space. So the condition should > be '*ntevs == 0' not 'ntevs == 0'. Oops, good catch! Acked-by: Masami Hiramatsu Thanks! > > Fixes: 42bba263eb58 ("perf probe: Allow wildcard for cached events") > Signed-off-by: Ravi Bangoria > --- > tools/perf/util/probe-event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 28fb62c..4f9d6ee 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -3057,7 +3057,7 @@ concat_probe_trace_events(struct probe_trace_event **tevs, int *ntevs, > struct probe_trace_event *new_tevs; > int ret = 0; > > - if (ntevs == 0) { > + if (*ntevs == 0) { > *tevs = *tevs2; > *ntevs = ntevs2; > *tevs2 = NULL; > -- > 2.9.3 > -- Masami Hiramatsu