* [PATCH v1] usb: gadget: udc: atmel: Remove an unused local variable
@ 2017-03-09 17:02 ` Romain Izard
0 siblings, 0 replies; 4+ messages in thread
From: Romain Izard @ 2017-03-09 17:02 UTC (permalink / raw)
To: linux-usb, linux-kernel, linux-arm-kernel, Nicolas Ferre,
Felipe Balbi, Greg Kroah-Hartman
Cc: Romain Izard
The local variable ept_cfg is not used anymore in usba_ep_enable.
Use ep->ept_cfg in the debug function to remove a warning when building
with dynamic debug enabled.
Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme")
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 11bbce28bc23..2035906b8ced 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -610,7 +610,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc)
{
struct usba_ep *ep = to_usba_ep(_ep);
struct usba_udc *udc = ep->udc;
- unsigned long flags, ept_cfg, maxpacket;
+ unsigned long flags, maxpacket;
unsigned int nr_trans;
DBG(DBG_GADGET, "%s: ep_enable: desc=%p\n", ep->ep.name, desc);
@@ -630,7 +630,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc)
ep->is_in = 0;
DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n",
- ep->ep.name, ept_cfg, maxpacket);
+ ep->ep.name, ep->ept_cfg, maxpacket);
if (usb_endpoint_dir_in(desc)) {
ep->is_in = 1;
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1] usb: gadget: udc: atmel: Remove an unused local variable
@ 2017-03-09 17:02 ` Romain Izard
0 siblings, 0 replies; 4+ messages in thread
From: Romain Izard @ 2017-03-09 17:02 UTC (permalink / raw)
To: linux-arm-kernel
The local variable ept_cfg is not used anymore in usba_ep_enable.
Use ep->ept_cfg in the debug function to remove a warning when building
with dynamic debug enabled.
Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme")
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 11bbce28bc23..2035906b8ced 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -610,7 +610,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc)
{
struct usba_ep *ep = to_usba_ep(_ep);
struct usba_udc *udc = ep->udc;
- unsigned long flags, ept_cfg, maxpacket;
+ unsigned long flags, maxpacket;
unsigned int nr_trans;
DBG(DBG_GADGET, "%s: ep_enable: desc=%p\n", ep->ep.name, desc);
@@ -630,7 +630,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc)
ep->is_in = 0;
DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n",
- ep->ep.name, ept_cfg, maxpacket);
+ ep->ep.name, ep->ept_cfg, maxpacket);
if (usb_endpoint_dir_in(desc)) {
ep->is_in = 1;
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] usb: gadget: udc: atmel: Remove an unused local variable
2017-03-09 17:02 ` Romain Izard
@ 2017-03-10 15:30 ` Romain Izard
-1 siblings, 0 replies; 4+ messages in thread
From: Romain Izard @ 2017-03-10 15:30 UTC (permalink / raw)
To: linux-usb, LKML, linux-arm-kernel, Nicolas Ferre, Felipe Balbi,
Greg Kroah-Hartman
Cc: Romain Izard
2017-03-09 18:02 GMT+01:00 Romain Izard <romain.izard.pro@gmail.com>:
> The local variable ept_cfg is not used anymore in usba_ep_enable.
> Use ep->ept_cfg in the debug function to remove a warning when building
> with dynamic debug enabled.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme")
Sorry for the noise, 4242820277b5 ("usb: gadget: udc: atmel: fix debug
output") in Greg KH's tree already fixed this.
--
Romain Izard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1] usb: gadget: udc: atmel: Remove an unused local variable
@ 2017-03-10 15:30 ` Romain Izard
0 siblings, 0 replies; 4+ messages in thread
From: Romain Izard @ 2017-03-10 15:30 UTC (permalink / raw)
To: linux-arm-kernel
2017-03-09 18:02 GMT+01:00 Romain Izard <romain.izard.pro@gmail.com>:
> The local variable ept_cfg is not used anymore in usba_ep_enable.
> Use ep->ept_cfg in the debug function to remove a warning when building
> with dynamic debug enabled.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme")
Sorry for the noise, 4242820277b5 ("usb: gadget: udc: atmel: fix debug
output") in Greg KH's tree already fixed this.
--
Romain Izard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-10 15:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-09 17:02 [PATCH v1] usb: gadget: udc: atmel: Remove an unused local variable Romain Izard
2017-03-09 17:02 ` Romain Izard
2017-03-10 15:30 ` Romain Izard
2017-03-10 15:30 ` Romain Izard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.