Re: [Qemu-devel] [RFC 2/4] raw-format: add bdrv_max_size() support

From: Stefan Hajnoczi <stefanha@gmail.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Nir Soffer <nsoffer@redhat.com>,
	Maor Lipchuk <mlipchuk@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [RFC 2/4] raw-format: add bdrv_max_size() support
Date: Fri, 10 Mar 2017 12:33:44 +0800	[thread overview]
Message-ID: <20170310043344.GD4589@stefanha-x1.localdomain> (raw)
In-Reply-To: <w51k2812x8i.fsf@maestria.local.igalia.com>

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

On Tue, Mar 07, 2017 at 11:32:29AM +0100, Alberto Garcia wrote:
> On Fri 03 Mar 2017 02:51:48 PM CET, Stefan Hajnoczi wrote:
> 
> > +static uint64_t raw_max_size(QemuOpts *opts, BlockDriverState *in_bs,
> > +                             Error **errp)
> > +{
> > +    if (in_bs) {
> > +        int64_t size = bdrv_nb_sectors(in_bs);
> > +        if (size < 0) {
> > +            error_setg_errno(errp, -size, "Unable to get image size");
> > +            return 0;
> > +        }
> > +        return (uint64_t)size * BDRV_SECTOR_SIZE;
> > +    }
> 
> Why not use bdrv_getlength() directly? It gives you the size in bytes.

Good idea.  Will fix.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]