From: Simon Horman <horms@verge.net.au>
To: David Woodhouse <dwmw2@infradead.org>
Cc: kexec@lists.infradead.org, Khem Raj <raj.khem@gmail.com>
Subject: Re: [PATCH] vmcore-dmesg: Define _GNU_SOURCE
Date: Fri, 10 Mar 2017 10:12:10 +0100 [thread overview]
Message-ID: <20170310091210.GB21820@verge.net.au> (raw)
In-Reply-To: <1489002280.4347.149.camel@infradead.org>
On Wed, Mar 08, 2017 at 08:44:40PM +0100, David Woodhouse wrote:
> On Sat, 2016-01-09 at 17:21 -0800, Khem Raj wrote:
> > loff_t is guarded with _GNU_SOURCE on some C library implementations
> > e.g. musl since this type is not defined by POSIX. Define _GNU_SOURCE to
> > include this define, it should help compiling on musl while nothing
> > changes for glibc based systems since there _GNU_SOURCE is already
> > defined
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>
> This appears to still be needed...
For some reason it did not hit my inbox :(
Shall I pick up the version you reposted as PATCH 7/7 ?
> > ---
> > vmcore-dmesg/vmcore-dmesg.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c
> > index 0364636..a8f56df 100644
> > --- a/vmcore-dmesg/vmcore-dmesg.c
> > +++ b/vmcore-dmesg/vmcore-dmesg.c
> > @@ -1,4 +1,5 @@
> > #define _XOPEN_SOURCE 600
> > +#define _GNU_SOURCE
> > #define _LARGEFILE_SOURCE 1
> > #define _FILE_OFFSET_BITS 64
> > #include
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-03-10 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 1:21 [PATCH] vmcore-dmesg: Define _GNU_SOURCE Khem Raj
2017-03-08 19:44 ` David Woodhouse
2017-03-10 9:12 ` Simon Horman [this message]
2017-03-10 9:38 ` David Woodhouse
2017-03-13 9:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310091210.GB21820@verge.net.au \
--to=horms@verge.net.au \
--cc=dwmw2@infradead.org \
--cc=kexec@lists.infradead.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.