All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yunlei He <heyunlei@huawei.com>
To: jaegeuk@kernel.org, yuchao0@huawei.com,
	linux-f2fs-devel@lists.sourceforge.net
Subject: [PATCH 2/2] f2fs: avoid move encrypted block in BG_GC if it has been in memory
Date: Fri, 10 Mar 2017 17:50:47 +0800	[thread overview]
Message-ID: <20170310095047.14540-2-heyunlei@huawei.com> (raw)
In-Reply-To: <20170310095047.14540-1-heyunlei@huawei.com>

If an encrypted block has been read to memory, we just dirty it
and return directly.

Signed-off-by: Yunlei He <heyunlei@huawei.com>
---
 fs/f2fs/gc.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 418fd98..ca94518 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -564,7 +564,7 @@ static bool is_alive(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,
 }
 
 static void move_encrypted_block(struct inode *inode, block_t bidx,
-							unsigned int segno, int off)
+					int gc_type, unsigned int segno, int off)
 {
 	struct f2fs_io_info fio = {
 		.sbi = F2FS_I_SB(inode),
@@ -607,6 +607,12 @@ static void move_encrypted_block(struct inode *inode, block_t bidx,
 	 */
 	f2fs_wait_on_page_writeback(page, DATA, true);
 
+	if (gc_type == BG_GC && PageUptodate(page) &&
+				fscrypt_has_encryption_key(inode)) {
+		set_page_dirty(page);
+		goto put_out;
+	}
+
 	get_node_info(fio.sbi, dn.nid, &ni);
 	set_summary(&sum, dn.nid, dn.ofs_in_node, ni.version);
 
@@ -827,7 +833,8 @@ static void gc_data_segment(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,
 			start_bidx = start_bidx_of_node(nofs, inode)
 								+ ofs_in_node;
 			if (f2fs_encrypted_inode(inode) && S_ISREG(inode->i_mode))
-				move_encrypted_block(inode, start_bidx, segno, off);
+				move_encrypted_block(inode, start_bidx,
+								gc_type, segno, off);
 			else
 				move_data_page(inode, start_bidx, gc_type, segno, off);
 
-- 
2.10.1


------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford

  reply	other threads:[~2017-03-10  9:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10  9:50 [dev-test][PATCH 1/2] f2fs: add a missing truncate_inode_pages_final Yunlei He
2017-03-10  9:50 ` Yunlei He [this message]
2017-03-13 18:30   ` [PATCH 2/2] f2fs: avoid move encrypted block in BG_GC if it has been in memory Jaegeuk Kim
2017-03-14  1:37     ` heyunlei
2017-03-14  3:42       ` Chao Yu
2017-03-17  1:49 ` [dev-test][PATCH 1/2] f2fs: add a missing truncate_inode_pages_final Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170310095047.14540-2-heyunlei@huawei.com \
    --to=heyunlei@huawei.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.