All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: mmarek@suse.com
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Wei Yang <richard.weiyang@gmail.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: [PATCH] kbuild: strip the last slash in KBUILD_EXTMOD
Date: Sun, 12 Mar 2017 20:01:14 +0800	[thread overview]
Message-ID: <20170312120114.14296-1-richard.weiyang@gmail.com> (raw)

Current kbuild will build the target again if we run "make M=dir" and "make
M=dir/" by turns, since if_changed will see the prerequisite is changed.
The behavior may confuse the user a little, since actually we are building
the same target and no difference.

According to current implementation in scripts/Makefile.build, the obj
passed to next level is a directory name with last slash stripped. This
patch strips the last slash, and slashes in case user doing so, in
KBUILD_EXTMOD which is assigned from "M=".

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: Masahiro Yamada <yamada.masahiro@socionext.com>

---
v2:
   * remote the temp variable __KBUILD_EXTMOD, since this breaks the user
     case
   * use realpath to strips all the slash at the end, then remote the
     common part if it is an in tree build to make it the same behavior as
     previous version
---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Makefile b/Makefile
index b8dfb24b1911..7f12e88cc0fb 100644
--- a/Makefile
+++ b/Makefile
@@ -191,6 +191,8 @@ ifeq ("$(origin M)", "command line")
   KBUILD_EXTMOD := $(M)
 endif
 
+KBUILD_EXTMOD := $(subst $(CURDIR)/,,$(realpath $(KBUILD_EXTMOD)))
+
 # If building an external module we do not care about the all: rule
 # but instead _all depend on modules
 PHONY += all
-- 
2.11.0

             reply	other threads:[~2017-03-12 12:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-12 12:01 Wei Yang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-02-22 15:08 [PATCH] kbuild: strip the last slash in KBUILD_EXTMOD Wei Yang
2017-03-11 13:34 ` Masahiro Yamada
2017-03-12 11:56   ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170312120114.14296-1-richard.weiyang@gmail.com \
    --to=richard.weiyang@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.