From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934018AbdCLO2A (ORCPT ); Sun, 12 Mar 2017 10:28:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47296 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932364AbdCLO1z (ORCPT ); Sun, 12 Mar 2017 10:27:55 -0400 Date: Sun, 12 Mar 2017 15:27:34 +0100 From: Greg KH To: Radoslaw Pietrzyk Cc: thomas.petazzoni@free-electrons.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: Allows bpp to be set from dt Message-ID: <20170312142734.GA19066@kroah.com> References: <1489137927-13347-1-git-send-email-radoslaw.pietrzyk@gmail.com> <1489137927-13347-2-git-send-email-radoslaw.pietrzyk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489137927-13347-2-git-send-email-radoslaw.pietrzyk@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 10, 2017 at 10:25:27AM +0100, Radoslaw Pietrzyk wrote: > Allows bpp to be set from dt > > Signed-off-by: Radoslaw Pietrzyk > --- > drivers/staging/fbtft/fbtft-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c > index 7c8af29..b25288b 100644 > --- a/drivers/staging/fbtft/fbtft-core.c > +++ b/drivers/staging/fbtft/fbtft-core.c > @@ -685,6 +685,8 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display, > /* override driver values? */ > if (pdata->fps) > fps = pdata->fps; > + if (pdata->bpp) > + bpp = pdata->bpp; > if (pdata->txbuflen) > txbuflen = pdata->txbuflen; > if (pdata->display.init_sequence) This breaks the build, how did you test this??? thanks, greg k-h