From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed Date: Mon, 13 Mar 2017 12:56:14 -0700 (PDT) Message-ID: <20170313.125614.724873987813626999.davem@davemloft.net> References: <1489008801-120389-1-git-send-email-darcari@redhat.com> <20170312.230919.811312629901809185.davem@davemloft.net> <5a3a435e-2ea5-343b-49e9-aff185eb73cc@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Pavel.Belous@aquantia.com To: darcari@redhat.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:55178 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbdCMT4Q (ORCPT ); Mon, 13 Mar 2017 15:56:16 -0400 In-Reply-To: <5a3a435e-2ea5-343b-49e9-aff185eb73cc@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: David Arcari Date: Mon, 13 Mar 2017 11:50:50 -0400 > On 03/13/2017 02:09 AM, David Miller wrote: >> From: David Arcari >> Date: Wed, 8 Mar 2017 16:33:21 -0500 >> >>> When the aquantia device mtu is changed the net_device structure is not >>> updated. As a result the ip command does not properly reflect the mtu change. >>> >>> Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the >>> assignment ndev->mtu = new_mtu; This is not true in the case where the driver >>> has a ndo_change_mtu routine. >>> >>> Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu") >>> >>> Cc: Pavel Belous >>> Signed-off-by: David Arcari >> >> Applied, thanks. >> > > Hi David, > > I see that my patch: > > "net: ethernet: aquantia: call set_irq_affinity_hint before free_irq" > > has been applied to net, but I don't see that this patch has been applied. It is marked as "changes requested" in patchwork, because you were asked to do the restart label removal in a separate patch.