From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752662AbdCMJRH (ORCPT ); Mon, 13 Mar 2017 05:17:07 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:45756 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752414AbdCMJQz (ORCPT ); Mon, 13 Mar 2017 05:16:55 -0400 Date: Mon, 13 Mar 2017 10:16:30 +0100 From: Peter Zijlstra To: Sebastian Andrzej Siewior Cc: tglx@linutronix.de, mingo@kernel.org, juri.lelli@arm.com, rostedt@goodmis.org, xlpang@redhat.com, linux-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, jdesfossez@efficios.com, bristot@redhat.com, dvhart@infradead.org Subject: Re: [PATCH] futex: move debug_rt_mutex_free_waiter() further down Message-ID: <20170313091630.GI3343@twins.programming.kicks-ass.net> References: <20170304092717.762954142@infradead.org> <20170304093559.546712677@infradead.org> <20170308152901.kumylhi7l3hescxd@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170308152901.kumylhi7l3hescxd@linutronix.de> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 08, 2017 at 04:29:02PM +0100, Sebastian Andrzej Siewior wrote: > kernel/futex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/futex.c b/kernel/futex.c > index 00ec4a01d3f5..73abfe0da4d0 100644 > --- a/kernel/futex.c > +++ b/kernel/futex.c > @@ -3046,11 +3046,11 @@ static int futex_wait_requeue_pi(u32 __user *uaddr, unsigned int flags, > WARN_ON(!q.pi_state); > pi_mutex = &q.pi_state->pi_mutex; > ret = rt_mutex_wait_proxy_lock(pi_mutex, to, &rt_waiter); > - debug_rt_mutex_free_waiter(&rt_waiter); > > spin_lock(q.lock_ptr); > if (ret && !rt_mutex_cleanup_proxy_lock(pi_mutex, &rt_waiter)) > ret = 0; > + debug_rt_mutex_free_waiter(&rt_waiter); > > /* > * Fixup the pi_state owner and possibly acquire the lock if we > Thanks, folded.