From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753725AbdCNADL (ORCPT ); Mon, 13 Mar 2017 20:03:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49466 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbdCNADD (ORCPT ); Mon, 13 Mar 2017 20:03:03 -0400 Date: Tue, 14 Mar 2017 08:02:50 +0800 From: Greg KH To: Gioh Kim Cc: sergio.paracuellos@gmail.com, devel@driverdev.osuosl.org, gurugio@hanmail.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: wlan-ng: introduce a macro read_u16 Message-ID: <20170314000250.GA32002@kroah.com> References: <1489410866-19639-1-git-send-email-gi-oh.kim@profitbricks.com> <1489410866-19639-2-git-send-email-gi-oh.kim@profitbricks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489410866-19639-2-git-send-email-gi-oh.kim@profitbricks.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 13, 2017 at 02:14:25PM +0100, Gioh Kim wrote: > read_u16 is wrapper of le16_to_cpu to read u16 variable, > rather than __le16. > > Signed-off-by: Gioh Kim > --- > drivers/staging/wlan-ng/prism2mgmt.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h > index 88b979f..97ede25 100644 > --- a/drivers/staging/wlan-ng/prism2mgmt.h > +++ b/drivers/staging/wlan-ng/prism2mgmt.h > @@ -63,6 +63,9 @@ > extern int prism2_reset_holdtime; > extern int prism2_reset_settletime; > > +#define read_u16(x) ({ u32 __r = (u32)le16_to_cpu((__force __le16)(x)); \ > + __r; }) > + Eeek, no, this should not be needed at all, if the code is written correctly. Please fix things up to work properly, don't paper over them with forced casts. thanks, greg k-h