From mboxrd@z Thu Jan 1 00:00:00 1970 From: Song Liu Subject: [PATCH v2] r5cache: allow adding journal to array without journal Date: Mon, 13 Mar 2017 17:11:38 -0700 Message-ID: <20170314001138.2194394-1-songliubraving@fb.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Sender: linux-raid-owner@vger.kernel.org To: linux-raid@vger.kernel.org Cc: shli@fb.com, neilb@suse.com, kernel-team@fb.com, dan.j.williams@intel.com, hch@infradead.org, jsorensen@fb.com, Song Liu List-Id: linux-raid.ids This seems just work. Signed-off-by: Song Liu --- Manage.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/Manage.c b/Manage.c index 5c3d2b9..5ff5de3 100644 --- a/Manage.c +++ b/Manage.c @@ -946,7 +946,6 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv, /* only add journal to array that supports journaling */ if (dv->disposition == 'j') { - struct mdinfo mdi; struct mdinfo *mdp; mdp = sysfs_read(fd, NULL, GET_ARRAY_STATE); @@ -963,11 +962,6 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv, sysfs_free(mdp); - tst->ss->getinfo_super(tst, &mdi, NULL); - if (mdi.journal_device_required == 0) { - pr_err("%s does not support journal device.\n", devname); - return -1; - } disc.raid_disk = 0; } -- 2.9.3