From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752994AbdCNAwt (ORCPT ); Mon, 13 Mar 2017 20:52:49 -0400 Received: from muru.com ([72.249.23.125]:39402 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752012AbdCNAws (ORCPT ); Mon, 13 Mar 2017 20:52:48 -0400 From: Tony Lindgren To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org Subject: [PATCH] genirq: Fix handle_nested_irq() for IRQF_SHARED Date: Mon, 13 Mar 2017 17:52:40 -0700 Message-Id: <20170314005240.18911-1-tony@atomide.com> X-Mailer: git-send-email 2.11.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shared interrupts can be registered with handle_nested_irq(), but currently only one of the registered handlers gets called. The use of shared interrupts with handle_nested_irq() is probably rare, but at least a case of a shared VBUS interrupt between USB PHY and battery charger drivers for a PMIC makes sense. Typically for_each_action_of_desc() gets called via handle_irq_event() at _handle_irq_event_percpu(), but handle_nested_irq() is different because of it's dummy irq_nested_primary_handler(). Let's fix the issue by calling the handler for all the entries in the action list. Fixes: 399b5da29b9f ("genirq: Support nested threaded irq handling") Signed-off-by: Tony Lindgren --- kernel/irq/chip.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -348,9 +348,11 @@ void handle_nested_irq(unsigned int irq) irqd_set(&desc->irq_data, IRQD_IRQ_INPROGRESS); raw_spin_unlock_irq(&desc->lock); - action_ret = action->thread_fn(action->irq, action->dev_id); - if (!noirqdebug) - note_interrupt(desc, action_ret); + for_each_action_of_desc(desc, action) { + action_ret = action->thread_fn(action->irq, action->dev_id); + if (!noirqdebug) + note_interrupt(desc, action_ret); + } raw_spin_lock_irq(&desc->lock); irqd_clear(&desc->irq_data, IRQD_IRQ_INPROGRESS); -- 2.11.1