From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH kernel v8 00/10] powerpc/kvm/vfio: Enable in-kernel acceleration Date: Tue, 14 Mar 2017 11:55:33 +1100 Message-ID: <20170314005533.GC12564@umbus.fritz.box> References: <20170310035337.22091-1-aik@ozlabs.ru> <20170310044813.GB3167@umbus.fritz.box> <0c355414-253f-2ceb-b45e-90d8c01fafdf@ozlabs.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sHrvAb52M6C8blB9" Cc: Alex Williamson , linuxppc-dev@lists.ozlabs.org, Paul Mackerras , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: Alexey Kardashevskiy Return-path: Received: from ozlabs.org ([103.22.144.67]:36177 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752140AbdCNAzj (ORCPT ); Mon, 13 Mar 2017 20:55:39 -0400 Content-Disposition: inline In-Reply-To: <0c355414-253f-2ceb-b45e-90d8c01fafdf@ozlabs.ru> Sender: kvm-owner@vger.kernel.org List-ID: --sHrvAb52M6C8blB9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 14, 2017 at 11:54:03AM +1100, Alexey Kardashevskiy wrote: > On 10/03/17 15:48, David Gibson wrote: > > On Fri, Mar 10, 2017 at 02:53:27PM +1100, Alexey Kardashevskiy wrote: > >> This is my current queue of patches to add acceleration of TCE > >> updates in KVM. > >> > >> This is based on Linus'es tree sha1 c1aa905a304e. > >=20 > > I think we're finally there - I've now sent an R-b for all patches. >=20 > Thanks for the patience. >=20 >=20 > I supposed in order to proceed now I need an ack from Alex, correct? That, or simply for him to merge it. >=20 >=20 > >=20 > >=20 > >> > >> Please comment. Thanks. > >> > >> Changes: > >> v8: > >> * kept fixing oddities with error handling in 10/10 > >> > >> v7: > >> * added realmode's WARN_ON_ONCE_RM in arch/powerpc/kvm/book3s_64_vio_h= v.c > >> > >> v6: > >> * reworked the last patch in terms of error handling and parameters ch= ecking > >> > >> v5: > >> * replaced "KVM: PPC: Separate TCE validation from update" with > >> "KVM: PPC: iommu: Unify TCE checking" > >> * changed already reviewed "powerpc/iommu/vfio_spapr_tce: Cleanup iomm= u_table disposal" > >> * reworked "KVM: PPC: VFIO: Add in-kernel acceleration for VFIO" > >> * more details in individual commit logs > >> > >> v4: > >> * addressed comments from v3 > >> * updated subject lines with correct component names > >> * regrouped the patchset in order: > >> - powerpc fixes; > >> - vfio_spapr_tce driver fixes; > >> - KVM/PPC fixes; > >> - KVM+PPC+VFIO; > >> * everything except last 2 patches have "Reviewed-By: David" > >> > >> v3: > >> * there was no full repost, only last patch was posted > >> > >> v2: > >> * 11/11 reworked to use new notifiers, it is rather RFC as it still has > >> a issue; > >> * got 09/11, 10/11 to use notifiers in 11/11; > >> * added rb: David to most of patches and added a comment in 05/11. > >> > >> Alexey Kardashevskiy (10): > >> powerpc/mmu: Add real mode support for IOMMU preregistered memory > >> powerpc/powernv/iommu: Add real mode version of > >> iommu_table_ops::exchange() > >> powerpc/iommu/vfio_spapr_tce: Cleanup iommu_table disposal > >> powerpc/vfio_spapr_tce: Add reference counting to iommu_table > >> KVM: PPC: Reserve KVM_CAP_SPAPR_TCE_VFIO capability number > >> KVM: PPC: Enable IOMMU_API for KVM_BOOK3S_64 permanently > >> KVM: PPC: Pass kvm* to kvmppc_find_table() > >> KVM: PPC: Use preregistered memory API to access TCE list > >> KVM: PPC: iommu: Unify TCE checking > >> KVM: PPC: VFIO: Add in-kernel acceleration for VFIO > >> > >> Documentation/virtual/kvm/devices/vfio.txt | 22 +- > >> arch/powerpc/include/asm/iommu.h | 32 ++- > >> arch/powerpc/include/asm/kvm_host.h | 8 + > >> arch/powerpc/include/asm/kvm_ppc.h | 12 +- > >> arch/powerpc/include/asm/mmu_context.h | 4 + > >> include/uapi/linux/kvm.h | 9 + > >> arch/powerpc/kernel/iommu.c | 86 +++++--- > >> arch/powerpc/kvm/book3s_64_vio.c | 330 ++++++++++++++++++++= ++++++++- > >> arch/powerpc/kvm/book3s_64_vio_hv.c | 303 ++++++++++++++++++++= ++---- > >> arch/powerpc/kvm/powerpc.c | 2 + > >> arch/powerpc/mm/mmu_context_iommu.c | 39 ++++ > >> arch/powerpc/platforms/powernv/pci-ioda.c | 46 ++-- > >> arch/powerpc/platforms/powernv/pci.c | 1 + > >> arch/powerpc/platforms/pseries/iommu.c | 3 +- > >> arch/powerpc/platforms/pseries/vio.c | 2 +- > >> drivers/vfio/vfio_iommu_spapr_tce.c | 2 +- > >> virt/kvm/vfio.c | 60 ++++++ > >> arch/powerpc/kvm/Kconfig | 1 + > >> 18 files changed, 855 insertions(+), 107 deletions(-) > >> > >=20 >=20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --sHrvAb52M6C8blB9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYxz+CAAoJEGw4ysog2bOSYdgP/jbbzoN9HZ5htC1m4xm+FS+n jafNMS2xIHAQw7JwdpoHXHgG36hv7/EpOxAKH1SEhwVrQpBbPhka4Np1cCYZXi8n FpkJxN8Lf4/TM3yZiOQJtP8j/p0Y0Aqhe5nwPE9LtNUIgXzDUz2a1KJN+kMKD7ib STiMhSdvLCMTpznZKS8tunMTFxBNhLU9NOwPgqQa+C3LGWGDIEdxV8uaAvJUlCSD miWsjXmjtQ+ZUK0HZk5TdJBr2M3ZRcwTIpKsbqm1uROeyWPJUQTY1N1wJHkhnNAt noW/lMht5sC4hV7XMTQmxurGuiYPmALnn+BMbA+xuOwFZmAgNaJtub5BysTWQOd9 e3zTC9mjcG2SmYhB4goRppCyk7ay5rbQLtPBtGDOzz/Iia3r5w964mlYo/QT7iMz q3K3JshvxyAgAOEiItk0zdGz4uCd1lCcuYLFUuEr5uWvpoLcByR3cxbjW/konbep ClvncNHlVcovtX7EKwBokDavWy2DdPJrzS/xiSzZeGbXQXruYSjDn7daHoB315xl XDXucyRhY+yPW5VvrvYtSCkvHBQTTWFd/ccXeq/OL6x1Z41pWjP5qHtbKtUXQFJX RD6o/8IqgM3fTmRiewLcj/+yQ3NerY5SO1/kG5KxtTT+AKS0PJKL69UdaSSg2UMc mqV6OndMWU0xMEqJKn4T =y8EA -----END PGP SIGNATURE----- --sHrvAb52M6C8blB9-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Date: Tue, 14 Mar 2017 00:55:33 +0000 Subject: Re: [PATCH kernel v8 00/10] powerpc/kvm/vfio: Enable in-kernel acceleration Message-Id: <20170314005533.GC12564@umbus.fritz.box> MIME-Version: 1 Content-Type: multipart/mixed; boundary="sHrvAb52M6C8blB9" List-Id: References: <20170310035337.22091-1-aik@ozlabs.ru> <20170310044813.GB3167@umbus.fritz.box> <0c355414-253f-2ceb-b45e-90d8c01fafdf@ozlabs.ru> In-Reply-To: <0c355414-253f-2ceb-b45e-90d8c01fafdf@ozlabs.ru> To: Alexey Kardashevskiy Cc: Alex Williamson , linuxppc-dev@lists.ozlabs.org, Paul Mackerras , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org --sHrvAb52M6C8blB9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 14, 2017 at 11:54:03AM +1100, Alexey Kardashevskiy wrote: > On 10/03/17 15:48, David Gibson wrote: > > On Fri, Mar 10, 2017 at 02:53:27PM +1100, Alexey Kardashevskiy wrote: > >> This is my current queue of patches to add acceleration of TCE > >> updates in KVM. > >> > >> This is based on Linus'es tree sha1 c1aa905a304e. > >=20 > > I think we're finally there - I've now sent an R-b for all patches. >=20 > Thanks for the patience. >=20 >=20 > I supposed in order to proceed now I need an ack from Alex, correct? That, or simply for him to merge it. >=20 >=20 > >=20 > >=20 > >> > >> Please comment. Thanks. > >> > >> Changes: > >> v8: > >> * kept fixing oddities with error handling in 10/10 > >> > >> v7: > >> * added realmode's WARN_ON_ONCE_RM in arch/powerpc/kvm/book3s_64_vio_h= v.c > >> > >> v6: > >> * reworked the last patch in terms of error handling and parameters ch= ecking > >> > >> v5: > >> * replaced "KVM: PPC: Separate TCE validation from update" with > >> "KVM: PPC: iommu: Unify TCE checking" > >> * changed already reviewed "powerpc/iommu/vfio_spapr_tce: Cleanup iomm= u_table disposal" > >> * reworked "KVM: PPC: VFIO: Add in-kernel acceleration for VFIO" > >> * more details in individual commit logs > >> > >> v4: > >> * addressed comments from v3 > >> * updated subject lines with correct component names > >> * regrouped the patchset in order: > >> - powerpc fixes; > >> - vfio_spapr_tce driver fixes; > >> - KVM/PPC fixes; > >> - KVM+PPC+VFIO; > >> * everything except last 2 patches have "Reviewed-By: David" > >> > >> v3: > >> * there was no full repost, only last patch was posted > >> > >> v2: > >> * 11/11 reworked to use new notifiers, it is rather RFC as it still has > >> a issue; > >> * got 09/11, 10/11 to use notifiers in 11/11; > >> * added rb: David to most of patches and added a comment in 05/11. > >> > >> Alexey Kardashevskiy (10): > >> powerpc/mmu: Add real mode support for IOMMU preregistered memory > >> powerpc/powernv/iommu: Add real mode version of > >> iommu_table_ops::exchange() > >> powerpc/iommu/vfio_spapr_tce: Cleanup iommu_table disposal > >> powerpc/vfio_spapr_tce: Add reference counting to iommu_table > >> KVM: PPC: Reserve KVM_CAP_SPAPR_TCE_VFIO capability number > >> KVM: PPC: Enable IOMMU_API for KVM_BOOK3S_64 permanently > >> KVM: PPC: Pass kvm* to kvmppc_find_table() > >> KVM: PPC: Use preregistered memory API to access TCE list > >> KVM: PPC: iommu: Unify TCE checking > >> KVM: PPC: VFIO: Add in-kernel acceleration for VFIO > >> > >> Documentation/virtual/kvm/devices/vfio.txt | 22 +- > >> arch/powerpc/include/asm/iommu.h | 32 ++- > >> arch/powerpc/include/asm/kvm_host.h | 8 + > >> arch/powerpc/include/asm/kvm_ppc.h | 12 +- > >> arch/powerpc/include/asm/mmu_context.h | 4 + > >> include/uapi/linux/kvm.h | 9 + > >> arch/powerpc/kernel/iommu.c | 86 +++++--- > >> arch/powerpc/kvm/book3s_64_vio.c | 330 ++++++++++++++++++++= ++++++++- > >> arch/powerpc/kvm/book3s_64_vio_hv.c | 303 ++++++++++++++++++++= ++---- > >> arch/powerpc/kvm/powerpc.c | 2 + > >> arch/powerpc/mm/mmu_context_iommu.c | 39 ++++ > >> arch/powerpc/platforms/powernv/pci-ioda.c | 46 ++-- > >> arch/powerpc/platforms/powernv/pci.c | 1 + > >> arch/powerpc/platforms/pseries/iommu.c | 3 +- > >> arch/powerpc/platforms/pseries/vio.c | 2 +- > >> drivers/vfio/vfio_iommu_spapr_tce.c | 2 +- > >> virt/kvm/vfio.c | 60 ++++++ > >> arch/powerpc/kvm/Kconfig | 1 + > >> 18 files changed, 855 insertions(+), 107 deletions(-) > >> > >=20 >=20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --sHrvAb52M6C8blB9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYxz+CAAoJEGw4ysog2bOSYdgP/jbbzoN9HZ5htC1m4xm+FS+n jafNMS2xIHAQw7JwdpoHXHgG36hv7/EpOxAKH1SEhwVrQpBbPhka4Np1cCYZXi8n FpkJxN8Lf4/TM3yZiOQJtP8j/p0Y0Aqhe5nwPE9LtNUIgXzDUz2a1KJN+kMKD7ib STiMhSdvLCMTpznZKS8tunMTFxBNhLU9NOwPgqQa+C3LGWGDIEdxV8uaAvJUlCSD miWsjXmjtQ+ZUK0HZk5TdJBr2M3ZRcwTIpKsbqm1uROeyWPJUQTY1N1wJHkhnNAt noW/lMht5sC4hV7XMTQmxurGuiYPmALnn+BMbA+xuOwFZmAgNaJtub5BysTWQOd9 e3zTC9mjcG2SmYhB4goRppCyk7ay5rbQLtPBtGDOzz/Iia3r5w964mlYo/QT7iMz q3K3JshvxyAgAOEiItk0zdGz4uCd1lCcuYLFUuEr5uWvpoLcByR3cxbjW/konbep ClvncNHlVcovtX7EKwBokDavWy2DdPJrzS/xiSzZeGbXQXruYSjDn7daHoB315xl XDXucyRhY+yPW5VvrvYtSCkvHBQTTWFd/ccXeq/OL6x1Z41pWjP5qHtbKtUXQFJX RD6o/8IqgM3fTmRiewLcj/+yQ3NerY5SO1/kG5KxtTT+AKS0PJKL69UdaSSg2UMc mqV6OndMWU0xMEqJKn4T =y8EA -----END PGP SIGNATURE----- --sHrvAb52M6C8blB9--