From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754349AbdCNA4q (ORCPT ); Mon, 13 Mar 2017 20:56:46 -0400 Received: from mga04.intel.com ([192.55.52.120]:63497 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754196AbdCNA4o (ORCPT ); Mon, 13 Mar 2017 20:56:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,161,1486454400"; d="scan'208";a="943932645" Date: Tue, 14 Mar 2017 08:56:34 +0800 From: Fengguang Wu To: Dave Jiang Cc: Matthew Wilcox , kbuild-all@01.org, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: Re: arch/x86/include/asm/pgtable.h:888:2: error: implicit declaration of function 'native_pud_clear' Message-ID: <20170314005634.27c5uggi3zb6i6z5@wfg-t540p.sh.intel.com> References: <201703120656.zGxXeJer%fengguang.wu@intel.com> <9d16b438-0b64-2292-7de3-1b8daebe621e@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <9d16b438-0b64-2292-7de3-1b8daebe621e@intel.com> User-Agent: NeoMutt/20161104 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dave, On Mon, Mar 13, 2017 at 08:57:54AM -0700, Dave Jiang wrote: >Fengguang, >I don't believe Andrew has picked up this patch yet: >http://marc.info/?l=linux-mm&m=148883870428812&w=2 > >Unless you are seeing issues with that patch. It looks the patch is not in mainline or linux-next yet: % git show linus/master:arch/x86/include/asm/pgtable-3level.h |grep -C3 CONFIG_PARAVIRT } #if !defined(CONFIG_SMP) || (defined(CONFIG_HIGHMEM64G) && \ defined(CONFIG_PARAVIRT)) static inline void native_pud_clear(pud_t *pudp) { } % git show linux-next/master:arch/x86/include/asm/pgtable-3level.h |grep -C3 CONFIG_PARAVIRT } #if !defined(CONFIG_SMP) || (defined(CONFIG_HIGHMEM64G) && \ defined(CONFIG_PARAVIRT)) static inline void native_pud_clear(pud_t *pudp) { } Thanks, Fengguang >On 03/11/2017 03:55 PM, kbuild test robot wrote: >> Hi Matthew, >> >> FYI, the error/warning still remains. >> >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >> head: 84c37c168c0e49a412d7021cda3183a72adac0d0 >> commit: a00cc7d9dd93d66a3fb83fc52aa57a4bec51c517 mm, x86: add support for PUD-sized transparent hugepages >> date: 2 weeks ago >> config: i386-randconfig-a0-201711 (attached as .config) >> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 >> reproduce: >> git checkout a00cc7d9dd93d66a3fb83fc52aa57a4bec51c517 >> # save the attached .config to linux build tree >> make ARCH=i386 >> >> All errors (new ones prefixed by >>): >> >> In file included from include/linux/mm.h:68:0, >> from include/linux/suspend.h:8, >> from arch/x86/kernel/asm-offsets.c:12: >> arch/x86/include/asm/pgtable.h: In function 'native_local_pudp_get_and_clear': >>>> arch/x86/include/asm/pgtable.h:888:2: error: implicit declaration of function 'native_pud_clear' [-Werror=implicit-function-declaration] >> native_pud_clear(pudp); >> ^~~~~~~~~~~~~~~~ >> cc1: some warnings being treated as errors >> make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1 >> make[2]: Target '__build' not remade because of errors. >> make[1]: *** [prepare0] Error 2 >> make[1]: Target 'prepare' not remade because of errors. >> make: *** [sub-make] Error 2 >> >> vim +/native_pud_clear +888 arch/x86/include/asm/pgtable.h >> >> 882 } >> 883 >> 884 static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp) >> 885 { >> 886 pud_t res = *pudp; >> 887 >> > 888 native_pud_clear(pudp); >> 889 return res; >> 890 } >> 891 >> >> --- >> 0-DAY kernel test infrastructure Open Source Technology Center >> https://lists.01.org/pipermail/kbuild-all Intel Corporation >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id 5584B6B0038 for ; Mon, 13 Mar 2017 20:56:39 -0400 (EDT) Received: by mail-pg0-f69.google.com with SMTP id b2so336701593pgc.6 for ; Mon, 13 Mar 2017 17:56:39 -0700 (PDT) Received: from mga02.intel.com (mga02.intel.com. [134.134.136.20]) by mx.google.com with ESMTPS id e10si12930837pgf.266.2017.03.13.17.56.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Mar 2017 17:56:38 -0700 (PDT) Date: Tue, 14 Mar 2017 08:56:34 +0800 From: Fengguang Wu Subject: Re: arch/x86/include/asm/pgtable.h:888:2: error: implicit declaration of function 'native_pud_clear' Message-ID: <20170314005634.27c5uggi3zb6i6z5@wfg-t540p.sh.intel.com> References: <201703120656.zGxXeJer%fengguang.wu@intel.com> <9d16b438-0b64-2292-7de3-1b8daebe621e@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <9d16b438-0b64-2292-7de3-1b8daebe621e@intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Dave Jiang Cc: Matthew Wilcox , kbuild-all@01.org, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Hi Dave, On Mon, Mar 13, 2017 at 08:57:54AM -0700, Dave Jiang wrote: >Fengguang, >I don't believe Andrew has picked up this patch yet: >http://marc.info/?l=linux-mm&m=148883870428812&w=2 > >Unless you are seeing issues with that patch. It looks the patch is not in mainline or linux-next yet: % git show linus/master:arch/x86/include/asm/pgtable-3level.h |grep -C3 CONFIG_PARAVIRT } #if !defined(CONFIG_SMP) || (defined(CONFIG_HIGHMEM64G) && \ defined(CONFIG_PARAVIRT)) static inline void native_pud_clear(pud_t *pudp) { } % git show linux-next/master:arch/x86/include/asm/pgtable-3level.h |grep -C3 CONFIG_PARAVIRT } #if !defined(CONFIG_SMP) || (defined(CONFIG_HIGHMEM64G) && \ defined(CONFIG_PARAVIRT)) static inline void native_pud_clear(pud_t *pudp) { } Thanks, Fengguang >On 03/11/2017 03:55 PM, kbuild test robot wrote: >> Hi Matthew, >> >> FYI, the error/warning still remains. >> >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >> head: 84c37c168c0e49a412d7021cda3183a72adac0d0 >> commit: a00cc7d9dd93d66a3fb83fc52aa57a4bec51c517 mm, x86: add support for PUD-sized transparent hugepages >> date: 2 weeks ago >> config: i386-randconfig-a0-201711 (attached as .config) >> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 >> reproduce: >> git checkout a00cc7d9dd93d66a3fb83fc52aa57a4bec51c517 >> # save the attached .config to linux build tree >> make ARCH=i386 >> >> All errors (new ones prefixed by >>): >> >> In file included from include/linux/mm.h:68:0, >> from include/linux/suspend.h:8, >> from arch/x86/kernel/asm-offsets.c:12: >> arch/x86/include/asm/pgtable.h: In function 'native_local_pudp_get_and_clear': >>>> arch/x86/include/asm/pgtable.h:888:2: error: implicit declaration of function 'native_pud_clear' [-Werror=implicit-function-declaration] >> native_pud_clear(pudp); >> ^~~~~~~~~~~~~~~~ >> cc1: some warnings being treated as errors >> make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1 >> make[2]: Target '__build' not remade because of errors. >> make[1]: *** [prepare0] Error 2 >> make[1]: Target 'prepare' not remade because of errors. >> make: *** [sub-make] Error 2 >> >> vim +/native_pud_clear +888 arch/x86/include/asm/pgtable.h >> >> 882 } >> 883 >> 884 static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp) >> 885 { >> 886 pud_t res = *pudp; >> 887 >> > 888 native_pud_clear(pudp); >> 889 return res; >> 890 } >> 891 >> >> --- >> 0-DAY kernel test infrastructure Open Source Technology Center >> https://lists.01.org/pipermail/kbuild-all Intel Corporation >> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org