From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753578AbdCNC3h (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Mar 2017 22:29:37 -0400
Received: from mga05.intel.com ([192.55.52.43]:56900 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752044AbdCNC3f (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Mar 2017 22:29:35 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,162,1486454400"; 
   d="scan'208";a="75748142"
Date: Tue, 14 Mar 2017 08:00:40 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] engine: mv_xor: remove redundant null check on cd
Message-ID: <20170314023039.GY2843@localhost>
References: <20170301140721.22341-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170301140721.22341-1-colin.king@canonical.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 01, 2017 at 02:07:21PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The check to see if cd is null is redundant, pdata->channels is
> never null at this point, and hence &pdata->channels[i] cannot
> be null, so remove the null check.
> 
> Detected by CoverityScan, CID#1357194 ("Logically Dead Code")

Applied after fixing subsystem name

-- 
~Vinod

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vinod Koul <vinod.koul@intel.com>
Date: Tue, 14 Mar 2017 02:42:40 +0000
Subject: Re: [PATCH] engine: mv_xor: remove redundant null check on cd
Message-Id: <20170314023039.GY2843@localhost>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20170301140721.22341-1-colin.king@canonical.com>
In-Reply-To: <20170301140721.22341-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Colin King <colin.king@canonical.com>
Cc: Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org

On Wed, Mar 01, 2017 at 02:07:21PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The check to see if cd is null is redundant, pdata->channels is
> never null at this point, and hence &pdata->channels[i] cannot
> be null, so remove the null check.
> 
> Detected by CoverityScan, CID#1357194 ("Logically Dead Code")

Applied after fixing subsystem name

-- 
~Vinod