From: Viresh Kumar <viresh.kumar@linaro.org>
To: Kevin Hilman <khilman@baylibre.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
linaro-kernel <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] PM / QOS: Remove the global notifiers
Date: Tue, 14 Mar 2017 08:35:31 +0530 [thread overview]
Message-ID: <20170314030531.GC3102@vireshk-i7> (raw)
In-Reply-To: <m2efy0c17f.fsf@baylibre.com>
On 13-03-17, 14:32, Kevin Hilman wrote:
> Ulf Hansson <ulf.hansson@linaro.org> writes:
>
> > On 13 March 2017 at 17:01, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >> On 22 February 2017 at 09:28, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >>> They were never used in the kernel, not sure why they got merged into
> >>> the kernel though. Get rid of them.
> >>
> >> commit b66213cdb002b08b29603d488c451dfe25e2ca20
> >> Author: Jean Pihet <j-pihet@ti.com>
> >> Date: Thu Aug 25 15:35:47 2011 +0200
> >>
> >> PM QoS: Add global notification mechanism for device constraints
> >>
> >> Add a global notification chain that gets called upon changes to the
> >> aggregated constraint value for any device.
> >> The notification callbacks are passing the full constraint request data
> >> in order for the callees to have access to it. The current use is for the
> >> platform low-level code to access the target device of the constraint.
> >>
> >> Signed-off-by: Jean Pihet <j-pihet@ti.com>
> >> Reviewed-by: Kevin Hilman <khilman@ti.com>
> >> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> >>
> >> It was a while ago since they were added, but it seems like
> >
> > Slipped on the keyboard, sorry for the noise.
> >
> > I was about to say, that it was a while ago these were added, but
> > still not being used. Thus let's remove them.
> >
> > Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Agreed. If we still have no users, let's remove them.
>
> Acked-by: Kevin Hilman <khilman@baylibre.com>
Its in Linus's tree for sometime now :)
Thanks for your Acks though
--
viresh
prev parent reply other threads:[~2017-03-14 3:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 8:28 [PATCH] PM / QOS: Remove the global notifiers Viresh Kumar
2017-03-13 16:01 ` Ulf Hansson
2017-03-13 16:04 ` Ulf Hansson
2017-03-13 21:32 ` Kevin Hilman
2017-03-13 21:32 ` Kevin Hilman
2017-03-14 3:05 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314030531.GC3102@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=khilman@baylibre.com \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.