From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dan.carpenter@oracle.com>
Date: Tue, 14 Mar 2017 12:23:14 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 08/12] staging: ks7010: remove unnecessary else statement
Message-ID: <20170314092314.GK4136@mwanda>
References: <1489445650-11398-1-git-send-email-me@tobin.cc>
 <1489445650-11398-9-git-send-email-me@tobin.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1489445650-11398-9-git-send-email-me@tobin.cc>
List-ID: <driverdev-devel.linuxdriverproject.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, driverdev-devel@linuxdriverproject.org, Wolfram Sang <wsa@the-dreams.de>

On Tue, Mar 14, 2017 at 09:54:06AM +1100, Tobin C. Harding wrote:
> @@ -2196,20 +2195,21 @@ static int ks_wlan_set_pmksa(struct net_device *dev,
>  	case IW_PMKSA_REMOVE:
>  		if (list_empty(&priv->pmklist.head)) {	/* list empty */
>  			return -EINVAL;
> -		} else {	/* search cache data */

We no longer need curly braces around the "return -EINVAL;".

> -			list_for_each(ptr, &priv->pmklist.head) {
> -				pmk = list_entry(ptr, struct pmk_t, list);
> -				if (!memcmp(pmksa->bssid.sa_data, pmk->bssid, ETH_ALEN)) {	/* match address! list del. */
> -					eth_zero_addr(pmk->bssid);
> -					memset(pmk->pmkid, 0, IW_PMKID_LEN);
> -					list_del_init(&pmk->list);
> -					break;
> -				}
> -			}
> -			if (ptr == &priv->pmklist.head) {	/* not find address. */
> -				return 0;
> +		}
> +		/* search cache data */
> +		list_for_each(ptr, &priv->pmklist.head) {
> +			pmk = list_entry(ptr, struct pmk_t, list);
> +			if (!memcmp(pmksa->bssid.sa_data, pmk->bssid, ETH_ALEN)) {	/* match address! list del. */
> +				eth_zero_addr(pmk->bssid);
> +				memset(pmk->pmkid, 0, IW_PMKID_LEN);
> +				list_del_init(&pmk->list);
> +				break;
>  			}
>  		}
> +		if (ptr == &priv->pmklist.head) {	/* not find address. */
> +			return 0;
> +		}

You can keep them here because the original had curly braces so it's
not like you're introducing a new warning.

Hopefully this example explains what "one thing per patch" means a bit
more clearly.  Removing the else means you are sort of required to
remove the curly braces so that's part of the "one thing" but fixing all
the curly braces issues is not required even if they are on lines that
you're modifying.

regards,
dan carpenter