From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <driverdev-devel-bounces@linuxdriverproject.org>
Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])
 by ash.osuosl.org (Postfix) with ESMTP id AA44F1BFCC4
 for <driverdev-devel@linuxdriverproject.org>;
 Tue, 14 Mar 2017 11:08:26 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by fraxinus.osuosl.org (Postfix) with ESMTP id A492788052
 for <driverdev-devel@linuxdriverproject.org>;
 Tue, 14 Mar 2017 11:08:26 +0000 (UTC)
Received: from fraxinus.osuosl.org ([127.0.0.1])
 by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id m4fMn5qoNMh4
 for <driverdev-devel@linuxdriverproject.org>;
 Tue, 14 Mar 2017 11:08:26 +0000 (UTC)
Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81])
 by fraxinus.osuosl.org (Postfix) with ESMTPS id 36A8D88057
 for <driverdev-devel@linuxdriverproject.org>;
 Tue, 14 Mar 2017 11:08:26 +0000 (UTC)
Date: Tue, 14 Mar 2017 14:08:17 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 10/12] staging: ks7010: fix checkpatch memset warning
Message-ID: <20170314110817.GR4136@mwanda>
References: <1489445650-11398-1-git-send-email-me@tobin.cc>
 <1489445650-11398-11-git-send-email-me@tobin.cc>
 <20170314092706.GL4136@mwanda> <20170314104407.GB15006@eros>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20170314104407.GB15006@eros>
List-Id: Linux Driver Project Developer List
 <driverdev-devel.linuxdriverproject.org>
List-Unsubscribe: <http://driverdev.linuxdriverproject.org/mailman/options/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=unsubscribe>
List-Archive: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/>
List-Post: <mailto:driverdev-devel@linuxdriverproject.org>
List-Help: <mailto:driverdev-devel-request@linuxdriverproject.org?subject=help>
List-Subscribe: <http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: driverdev-devel-bounces@linuxdriverproject.org
Sender: "devel" <driverdev-devel-bounces@linuxdriverproject.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, driverdev-devel@linuxdriverproject.org, Wolfram Sang <wsa@the-dreams.de>

On Tue, Mar 14, 2017 at 09:44:07PM +1100, Tobin C. Harding wrote:
> On Tue, Mar 14, 2017 at 12:27:07PM +0300, Dan Carpenter wrote:
> > This code is #ifdeffed out so you should just delete it instead of
> > fixing it.
> 
> The TODO file specifically asks for ifdeffed code not to be removed unless
> one knows exactly what is going on. I hope to get to that level but am
> not there yet.

Normally we just delete it.  I've never yet regretted doing that.  It's
still in the git log if people need it.

Don't be a hoarder.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel