From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbdCNOGF (ORCPT ); Tue, 14 Mar 2017 10:06:05 -0400 Received: from mail-wr0-f172.google.com ([209.85.128.172]:36623 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbdCNOFA (ORCPT ); Tue, 14 Mar 2017 10:05:00 -0400 Date: Tue, 14 Mar 2017 14:04:55 +0000 From: Lee Jones To: Joe Perches Cc: Linus Walleij , Tony Lindgren , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn Message-ID: <20170314140455.umlhdbuj3grqtu6i@dell> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Feb 2017, Joe Perches wrote: > To enable eventual removal of pr_warning > > This makes pr_warn use consistent for drivers/mfd > > Prior to this patch, there were 4 uses of pr_warning and > 9 uses of pr_warn in drivers/mfd > > Signed-off-by: Joe Perches > --- > drivers/mfd/db8500-prcmu.c | 2 +- > drivers/mfd/sta2x11-mfd.c | 4 ++-- > drivers/mfd/twl4030-power.c | 7 ++----- > 3 files changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c > index ca38a6a14110..5c739ac752e8 100644 > --- a/drivers/mfd/db8500-prcmu.c > +++ b/drivers/mfd/db8500-prcmu.c > @@ -2377,7 +2377,7 @@ static void ack_dbb_wakeup(void) > > static inline void print_unknown_header_warning(u8 n, u8 header) > { > - pr_warning("prcmu: Unknown message header (%d) in mailbox %d.\n", > + pr_warn("prcmu: Unknown message header (%d) in mailbox %d\n", > header, n); > } > > diff --git a/drivers/mfd/sta2x11-mfd.c b/drivers/mfd/sta2x11-mfd.c > index 9292202039ee..3aeafa228baf 100644 > --- a/drivers/mfd/sta2x11-mfd.c > +++ b/drivers/mfd/sta2x11-mfd.c > @@ -60,8 +60,8 @@ static struct sta2x11_mfd *sta2x11_mfd_find(struct pci_dev *pdev) > struct sta2x11_mfd *mfd; > > if (!pdev && !list_empty(&sta2x11_mfd_list)) { > - pr_warning("%s: Unspecified device, " > - "using first instance\n", __func__); > + pr_warn("%s: Unspecified device, using first instance\n", > + __func__); > return list_entry(sta2x11_mfd_list.next, > struct sta2x11_mfd, list); > } > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > index 1beb722f6080..8be023ba8e3e 100644 > --- a/drivers/mfd/twl4030-power.c > +++ b/drivers/mfd/twl4030-power.c > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, > } > if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > if (!order) > - pr_warning("TWL4030: Bad order of scripts (sleep "\ > - "script before wakeup) Leads to boot"\ > - "failure on some boards\n"); > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); Is 80 chars considered the lessor sin? > err = twl4030_config_sleep_sequence(address); > } > out: > @@ -929,8 +927,7 @@ static int twl4030_power_probe(struct platform_device *pdev) > err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val, > TWL4030_PM_MASTER_CFG_P123_TRANSITION); > if (err) { > - pr_warning("TWL4030 Unable to read registers\n"); > - > + pr_warn("TWL4030 Unable to read registers\n"); > } else if (!(val & SEQ_OFFSYNC)) { > val |= SEQ_OFFSYNC; > err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn Date: Tue, 14 Mar 2017 14:04:55 +0000 Message-ID: <20170314140455.umlhdbuj3grqtu6i@dell> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Joe Perches Cc: Tony Lindgren , Linus Walleij , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org T24gVGh1LCAxNiBGZWIgMjAxNywgSm9lIFBlcmNoZXMgd3JvdGU6Cgo+IFRvIGVuYWJsZSBldmVu dHVhbCByZW1vdmFsIG9mIHByX3dhcm5pbmcKPiAKPiBUaGlzIG1ha2VzIHByX3dhcm4gdXNlIGNv bnNpc3RlbnQgZm9yIGRyaXZlcnMvbWZkCj4gCj4gUHJpb3IgdG8gdGhpcyBwYXRjaCwgdGhlcmUg d2VyZSA0IHVzZXMgb2YgcHJfd2FybmluZyBhbmQKPiA5IHVzZXMgb2YgcHJfd2FybiBpbiBkcml2 ZXJzL21mZAo+IAo+IFNpZ25lZC1vZmYtYnk6IEpvZSBQZXJjaGVzIDxqb2VAcGVyY2hlcy5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvbWZkL2RiODUwMC1wcmNtdS5jICB8IDIgKy0KPiAgZHJpdmVycy9t ZmQvc3RhMngxMS1tZmQuYyAgIHwgNCArKy0tCj4gIGRyaXZlcnMvbWZkL3R3bDQwMzAtcG93ZXIu YyB8IDcgKystLS0tLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgOCBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvZGI4NTAwLXByY211LmMgYi9k cml2ZXJzL21mZC9kYjg1MDAtcHJjbXUuYwo+IGluZGV4IGNhMzhhNmExNDExMC4uNWM3MzlhYzc1 MmU4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWZkL2RiODUwMC1wcmNtdS5jCj4gKysrIGIvZHJp dmVycy9tZmQvZGI4NTAwLXByY211LmMKPiBAQCAtMjM3Nyw3ICsyMzc3LDcgQEAgc3RhdGljIHZv aWQgYWNrX2RiYl93YWtldXAodm9pZCkKPiAgCj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBwcmludF91 bmtub3duX2hlYWRlcl93YXJuaW5nKHU4IG4sIHU4IGhlYWRlcikKPiAgewo+IC0JcHJfd2Fybmlu ZygicHJjbXU6IFVua25vd24gbWVzc2FnZSBoZWFkZXIgKCVkKSBpbiBtYWlsYm94ICVkLlxuIiwK PiArCXByX3dhcm4oInByY211OiBVbmtub3duIG1lc3NhZ2UgaGVhZGVyICglZCkgaW4gbWFpbGJv eCAlZFxuIiwKPiAgCQloZWFkZXIsIG4pOwo+ICB9Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L21mZC9zdGEyeDExLW1mZC5jIGIvZHJpdmVycy9tZmQvc3RhMngxMS1tZmQuYwo+IGluZGV4IDky OTIyMDIwMzllZS4uM2FlYWZhMjI4YmFmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWZkL3N0YTJ4 MTEtbWZkLmMKPiArKysgYi9kcml2ZXJzL21mZC9zdGEyeDExLW1mZC5jCj4gQEAgLTYwLDggKzYw LDggQEAgc3RhdGljIHN0cnVjdCBzdGEyeDExX21mZCAqc3RhMngxMV9tZmRfZmluZChzdHJ1Y3Qg cGNpX2RldiAqcGRldikKPiAgCXN0cnVjdCBzdGEyeDExX21mZCAqbWZkOwo+ICAKPiAgCWlmICgh cGRldiAmJiAhbGlzdF9lbXB0eSgmc3RhMngxMV9tZmRfbGlzdCkpIHsKPiAtCQlwcl93YXJuaW5n KCIlczogVW5zcGVjaWZpZWQgZGV2aWNlLCAiCj4gLQkJCSAgICAidXNpbmcgZmlyc3QgaW5zdGFu Y2VcbiIsIF9fZnVuY19fKTsKPiArCQlwcl93YXJuKCIlczogVW5zcGVjaWZpZWQgZGV2aWNlLCB1 c2luZyBmaXJzdCBpbnN0YW5jZVxuIiwKPiArCQkJX19mdW5jX18pOwo+ICAJCXJldHVybiBsaXN0 X2VudHJ5KHN0YTJ4MTFfbWZkX2xpc3QubmV4dCwKPiAgCQkJCSAgc3RydWN0IHN0YTJ4MTFfbWZk LCBsaXN0KTsKPiAgCX0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvdHdsNDAzMC1wb3dlci5j IGIvZHJpdmVycy9tZmQvdHdsNDAzMC1wb3dlci5jCj4gaW5kZXggMWJlYjcyMmY2MDgwLi44YmUw MjNiYThlM2UgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tZmQvdHdsNDAzMC1wb3dlci5jCj4gKysr IGIvZHJpdmVycy9tZmQvdHdsNDAzMC1wb3dlci5jCj4gQEAgLTUwMiw5ICs1MDIsNyBAQCBzdGF0 aWMgaW50IGxvYWRfdHdsNDAzMF9zY3JpcHQoY29uc3Qgc3RydWN0IHR3bDQwMzBfcG93ZXJfZGF0 YSAqcGRhdGEsCj4gIAl9Cj4gIAlpZiAodHNjcmlwdC0+ZmxhZ3MgJiBUV0w0MDMwX1NMRUVQX1ND UklQVCkgewo+ICAJCWlmICghb3JkZXIpCj4gLQkJCXByX3dhcm5pbmcoIlRXTDQwMzA6IEJhZCBv cmRlciBvZiBzY3JpcHRzIChzbGVlcCAiXAo+IC0JCQkJCSJzY3JpcHQgYmVmb3JlIHdha2V1cCkg TGVhZHMgdG8gYm9vdCJcCj4gLQkJCQkJImZhaWx1cmUgb24gc29tZSBib2FyZHNcbiIpOwo+ICsJ CQlwcl93YXJuKCJUV0w0MDMwOiBCYWQgb3JkZXIgb2Ygc2NyaXB0cyAoc2xlZXAgc2NyaXB0IGJl Zm9yZSB3YWtldXApIExlYWRzIHRvIGJvb3QgZmFpbHVyZSBvbiBzb21lIGJvYXJkc1xuIik7CgpJ cyA4MCBjaGFycyBjb25zaWRlcmVkIHRoZSBsZXNzb3Igc2luPwoKPiAgCQllcnIgPSB0d2w0MDMw X2NvbmZpZ19zbGVlcF9zZXF1ZW5jZShhZGRyZXNzKTsKPiAgCX0KPiAgb3V0Ogo+IEBAIC05Mjks OCArOTI3LDcgQEAgc3RhdGljIGludCB0d2w0MDMwX3Bvd2VyX3Byb2JlKHN0cnVjdCBwbGF0Zm9y bV9kZXZpY2UgKnBkZXYpCj4gIAkJZXJyID0gdHdsX2kyY19yZWFkX3U4KFRXTF9NT0RVTEVfUE1f TUFTVEVSLCAmdmFsLAo+ICAJCQkJICAgICAgVFdMNDAzMF9QTV9NQVNURVJfQ0ZHX1AxMjNfVFJB TlNJVElPTik7Cj4gIAkJaWYgKGVycikgewo+IC0JCQlwcl93YXJuaW5nKCJUV0w0MDMwIFVuYWJs ZSB0byByZWFkIHJlZ2lzdGVyc1xuIik7Cj4gLQo+ICsJCQlwcl93YXJuKCJUV0w0MDMwIFVuYWJs ZSB0byByZWFkIHJlZ2lzdGVyc1xuIik7Cj4gIAkJfSBlbHNlIGlmICghKHZhbCAmIFNFUV9PRkZT WU5DKSkgewo+ICAJCQl2YWwgfD0gU0VRX09GRlNZTkM7Cj4gIAkJCWVyciA9IHR3bF9pMmNfd3Jp dGVfdTgoVFdMX01PRFVMRV9QTV9NQVNURVIsIHZhbCwKCi0tIApMZWUgSm9uZXMKTGluYXJvIFNU TWljcm9lbGVjdHJvbmljcyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNv dXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0 dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 14 Mar 2017 14:04:55 +0000 Subject: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn In-Reply-To: References: Message-ID: <20170314140455.umlhdbuj3grqtu6i@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 16 Feb 2017, Joe Perches wrote: > To enable eventual removal of pr_warning > > This makes pr_warn use consistent for drivers/mfd > > Prior to this patch, there were 4 uses of pr_warning and > 9 uses of pr_warn in drivers/mfd > > Signed-off-by: Joe Perches > --- > drivers/mfd/db8500-prcmu.c | 2 +- > drivers/mfd/sta2x11-mfd.c | 4 ++-- > drivers/mfd/twl4030-power.c | 7 ++----- > 3 files changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c > index ca38a6a14110..5c739ac752e8 100644 > --- a/drivers/mfd/db8500-prcmu.c > +++ b/drivers/mfd/db8500-prcmu.c > @@ -2377,7 +2377,7 @@ static void ack_dbb_wakeup(void) > > static inline void print_unknown_header_warning(u8 n, u8 header) > { > - pr_warning("prcmu: Unknown message header (%d) in mailbox %d.\n", > + pr_warn("prcmu: Unknown message header (%d) in mailbox %d\n", > header, n); > } > > diff --git a/drivers/mfd/sta2x11-mfd.c b/drivers/mfd/sta2x11-mfd.c > index 9292202039ee..3aeafa228baf 100644 > --- a/drivers/mfd/sta2x11-mfd.c > +++ b/drivers/mfd/sta2x11-mfd.c > @@ -60,8 +60,8 @@ static struct sta2x11_mfd *sta2x11_mfd_find(struct pci_dev *pdev) > struct sta2x11_mfd *mfd; > > if (!pdev && !list_empty(&sta2x11_mfd_list)) { > - pr_warning("%s: Unspecified device, " > - "using first instance\n", __func__); > + pr_warn("%s: Unspecified device, using first instance\n", > + __func__); > return list_entry(sta2x11_mfd_list.next, > struct sta2x11_mfd, list); > } > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > index 1beb722f6080..8be023ba8e3e 100644 > --- a/drivers/mfd/twl4030-power.c > +++ b/drivers/mfd/twl4030-power.c > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, > } > if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > if (!order) > - pr_warning("TWL4030: Bad order of scripts (sleep "\ > - "script before wakeup) Leads to boot"\ > - "failure on some boards\n"); > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); Is 80 chars considered the lessor sin? > err = twl4030_config_sleep_sequence(address); > } > out: > @@ -929,8 +927,7 @@ static int twl4030_power_probe(struct platform_device *pdev) > err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val, > TWL4030_PM_MASTER_CFG_P123_TRANSITION); > if (err) { > - pr_warning("TWL4030 Unable to read registers\n"); > - > + pr_warn("TWL4030 Unable to read registers\n"); > } else if (!(val & SEQ_OFFSYNC)) { > val |= SEQ_OFFSYNC; > err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog