From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
linus.walleij@linaro.org, gnurou@gmail.com,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v3 3/3] mfd: wm831x: Add device tree binding document
Date: Tue, 14 Mar 2017 14:59:35 +0000 [thread overview]
Message-ID: <20170314145935.3wy3ximhtuhw3fgc@dell> (raw)
In-Reply-To: <1488818804-9406-3-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Mon, 06 Mar 2017, Charles Keepax wrote:
> Add a device tree binding document for the wm831x series of PMICs.
> Currently only support for the registering the device and the GPIOs are
> actually implemented in the driver.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>
> Changes since v2:
> - Flesh the binding some more with some additional features of the device,
> although these are not yet implemented in the code.
>
> Documentation/devicetree/bindings/mfd/wm831x.txt | 81 ++++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 82 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/wm831x.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/wm831x.txt b/Documentation/devicetree/bindings/mfd/wm831x.txt
> new file mode 100644
> index 0000000..680ac18
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/wm831x.txt
> @@ -0,0 +1,81 @@
> +Cirrus Logic/Wolfson Microelectronics wm831x PMICs
> +
> +System PMICs with a wide range of additional features.
> +
> +Required properties:
> +
> + - compatible : One of the following chip-specific strings:
> + "wlf,wm8310"
> + "wlf,wm8311"
> + "wlf,wm8312"
> + "wlf,wm8320"
> + "wlf,wm8321"
> + "wlf,wm8325"
> + "wlf,wm8326"
> +
> + - reg : I2C slave address when connected using I2C, chip select number
> + when using SPI.
> +
> + - gpio-controller : Indicates this device is a GPIO controller.
> + - #gpio-cells : Must be 2. The first cell is the pin number and the
> + second cell is used to specify optional parameters (currently unused).
Then why not "must be 1", if the second cell is unused?
> + - interrupts : The interrupt line the /IRQ signal for the device is
> + connected to.
What's with the '/'?
> + - interrupt-parent : The parent interrupt controller.
> +
> + - interrupt-controller : wm831x devices contain interrupt controllers and
> + may provide interrupt services to other devices.
> + - #interrupt-cells: Must be 2. The first cell is the IRQ number, and the
> + second cell is the flags, encoded as the trigger masks from
> + Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
Please use the succinct "../../" format.
> +Optional sub-nodes:
> + - regulators : Contains sub-nodes for each of the regulators supplied by
> + the device. The regulators are bound using their names listed below:
> +
> + dcdc1 : DCDC1
> + dcdc2 : DCDC2
> + dcdc3 : DCDC3
> + dcdc4 : DCDC3
> + isink1 : ISINK1
> + isink2 : ISINK2
> + ldo1 : LDO1
> + ldo2 : LDO2
> + ldo3 : LDO3
> + ldo4 : LDO4
> + ldo5 : LDO5
> + ldo7 : LDO7
> + ldo11 : LDO11
> +
> + The bindings details of each regulator can be found in:
> + Documentation/devicetree/bindings/regulator/regulator.txt
As above.
> +Example:
> +
> +wm8310: pmic@36 {
> + compatible = "wlf,wm8310";
> + reg = <0x36>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + interrupts = <347>;
> + interrupt-parent = <&gic>;
> +
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + regulators {
> + dcdc1: dcdc1 {
> + regulator-name = "DCDC1";
> + regulator-min-microvolt = <600000>;
> + regulator-max-microvolt = <600000>;
> + };
> + ldo1: ldo1 {
> + regulator-name = "LDO1";
> + regulator-min-microvolt = <1700000>;
> + regulator-max-microvolt = <1700000>;
> + };
> + };
> +};
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2d8ca28..48fdc82 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13363,6 +13363,7 @@ F: Documentation/hwmon/wm83??
> F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> F: Documentation/devicetree/bindings/regulator/arizona-regulator.txt
> F: Documentation/devicetree/bindings/mfd/arizona.txt
> +F: Documentation/devicetree/bindings/mfd/wm831x.txt
> F: arch/arm/mach-s3c64xx/mach-crag6410*
> F: drivers/clk/clk-wm83*.c
> F: drivers/extcon/extcon-arizona.c
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-03-14 14:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 16:46 [PATCH v3 1/3] mfd: wm831x: Add basic device tree binding Charles Keepax
2017-03-06 16:46 ` Charles Keepax
[not found] ` <1488818804-9406-1-git-send-email-ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2017-03-06 16:46 ` [PATCH v3 2/3] gpio: wm831x: Add basic device tree support Charles Keepax
2017-03-06 16:46 ` Charles Keepax
2017-03-15 9:18 ` Linus Walleij
2017-03-15 9:18 ` Linus Walleij
2017-03-15 9:41 ` Charles Keepax
2017-03-15 9:41 ` Charles Keepax
2017-03-06 16:46 ` [PATCH v3 3/3] mfd: wm831x: Add device tree binding document Charles Keepax
2017-03-06 16:46 ` Charles Keepax
2017-03-14 14:59 ` Lee Jones [this message]
2017-03-15 15:24 ` Charles Keepax
2017-03-15 15:24 ` Charles Keepax
2017-03-14 14:56 ` [PATCH v3 1/3] mfd: wm831x: Add basic device tree binding Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314145935.3wy3ximhtuhw3fgc@dell \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.