On Tue, Mar 14, 2017 at 04:01:57PM +0200, Yuval Shaia wrote: > This logic seems to be duplicated in (at least) three separate files. > Move it to one place so code can be re-use. > > Signed-off-by: Yuval Shaia > --- > v0 -> v1: > * Add missing #include > * Rename to genaddrconf_ifid_eui48 > v1 -> v2: > * Reset eui[0] to default if dev_id is used > v2 -> v3: > * Add helper function to avoid re-setting eui[0] to default if > dev_id is used > v3 -> v4: > * Remove RXE wrappers > * Remove addrconf_addr_eui48_xor and do the eui[0] ^= 2 in the > basic implementation > --- > drivers/infiniband/hw/usnic/usnic_common_util.h | 11 +++------- > drivers/infiniband/sw/rxe/rxe.c | 4 +++- > drivers/infiniband/sw/rxe/rxe_loc.h | 2 -- > drivers/infiniband/sw/rxe/rxe_net.c | 28 ------------------------- > drivers/infiniband/sw/rxe/rxe_verbs.c | 4 +++- > include/net/addrconf.h | 22 +++++++++++++++---- > 6 files changed, 27 insertions(+), 44 deletions(-) > Thanks, Yuval. Reviewed-by: Leon Romanovsky