From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Subject: Re: [PATCH v1 17/22] KVM: x86: simplify pic_unlock() Date: Wed, 15 Mar 2017 16:27:24 +0800 Message-ID: <20170315082724.GB5971@pxdev.xzpeter.org> References: <20170314133450.13259-1-david@redhat.com> <20170314133450.13259-18-david@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: kvm@vger.kernel.org, Paolo Bonzini , rkrcmar@redhat.com To: David Hildenbrand Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56146 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbdCOI13 (ORCPT ); Wed, 15 Mar 2017 04:27:29 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D14C480465 for ; Wed, 15 Mar 2017 08:27:29 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170314133450.13259-18-david@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Mar 14, 2017 at 02:34:45PM +0100, David Hildenbrand wrote: > We can easily compact this code and get rid of one local variable. > > Signed-off-by: David Hildenbrand > --- > arch/x86/kvm/i8259.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c > index e77e8c3..c50b839 100644 > --- a/arch/x86/kvm/i8259.c > +++ b/arch/x86/kvm/i8259.c > @@ -49,7 +49,7 @@ static void pic_unlock(struct kvm_pic *s) > __releases(&s->lock) > { > bool wakeup = s->wakeup_needed; > - struct kvm_vcpu *vcpu, *found = NULL; > + struct kvm_vcpu *vcpu; > int i; > > s->wakeup_needed = false; > @@ -59,16 +59,11 @@ static void pic_unlock(struct kvm_pic *s) > if (wakeup) { > kvm_for_each_vcpu(i, vcpu, s->kvm) { > if (kvm_apic_accept_pic_intr(vcpu)) { > - found = vcpu; > + kvm_make_request(KVM_REQ_EVENT, vcpu); > + kvm_vcpu_kick(vcpu); > break; Maybe "return" directly here? Besides: Reviewed-by: Peter Xu > } > } > - > - if (!found) > - return; > - > - kvm_make_request(KVM_REQ_EVENT, found); > - kvm_vcpu_kick(found); > } > } > > -- > 2.9.3 > -- peterx