From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [PATCH v2 1/2] net/mlx5: add enhanced multi-packet
 send for ConnectX-5
Date: Wed, 15 Mar 2017 11:44:23 +0100
Message-ID: <20170315104423.GD22756@autoinstall.dev.6wind.com>
References: <20170310231334.2457-1-yskoh@mellanox.com>
 <20170310231334.2457-2-yskoh@mellanox.com>
 <20170315103907.GC22756@autoinstall.dev.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: ferruh.yigit@intel.com, dev@dpdk.org, adrien.mazarguil@6wind.com
To: Yongseok Koh <yskoh@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com
 [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 524A428F3
 for <dev@dpdk.org>; Wed, 15 Mar 2017 11:44:32 +0100 (CET)
Received: by mail-wr0-f171.google.com with SMTP id l37so8123411wrc.1
 for <dev@dpdk.org>; Wed, 15 Mar 2017 03:44:32 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20170315103907.GC22756@autoinstall.dev.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Mar 15, 2017 at 11:39:07AM +0100, Nélio Laranjeiro wrote:
> Hi Yongseok,
> 
> I did not see this v2, in the future please use the "in-reply-to" in
> addition of the --thread option.
> 
> Please see the comments below,
> 
>[...]
> >  
> > @@ -292,7 +298,11 @@ mlx5_args_check(const char *key, const char *val, void *opaque)
> >  	} else if (strcmp(MLX5_TXQS_MIN_INLINE, key) == 0) {
> >  		priv->txqs_inline = tmp;
> >  	} else if (strcmp(MLX5_TXQ_MPW_EN, key) == 0) {
> > -		priv->mps &= !!tmp; /* Enable MPW only if HW supports */
> > +		priv->mps = !!tmp ? priv->mps : MLX5_MPW_DISABLED;
> > +	} else if (strcmp(MLX5_TXQ_MPW_HDR_DSEG_EN, key) == 0) {
> > +		priv->mpw_hdr_dseg = !!tmp;
> > +	} else if (strcmp(MLX5_TXQ_MAX_INLINE_LEN, key) == 0) {
> > +		priv->txq_max_inline_len = tmp;
> >  	} else if (strcmp(MLX5_TSO, key) == 0) {
> 
> Is it really necessary to let the ConnectX-5 behave in the non enhanced
> feature?
>[...]

Sorry I did not read correctly.  Forget this remark.

Thanks,

-- 
Nélio Laranjeiro
6WIND