From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: Re: [PATCH] drm/i915/guc: Use formalized struct
 definition for ads object
Date: Wed, 15 Mar 2017 12:02:21 +0100
Message-ID: <20170315110221.GA155100@mwajdecz-MOBL1.ger.corp.intel.com>
References: <20170314133309.126432-1-michal.wajdeczko@intel.com>
 <20170314205302.14892-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 069036E884
 for <intel-gfx@lists.freedesktop.org>; Wed, 15 Mar 2017 11:02:24 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20170314205302.14892-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBNYXIgMTQsIDIwMTcgYXQgMDg6NTM6MDJQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IEZyb206IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29t
Pgo+IAo+IE1hbnVhbCBwb2ludGVyIG1hbmlwdWxhdGlvbiBpcyBlcnJvciBwcm9uZS4gTGV0IGNv
bXBpbGVyIGNhbGN1bGF0ZQo+IHJpZ2h0IG9mZnNldHMgZm9yIHVzIGluIGNhc2Ugd2UgbmVlZCB0
byBjaGFuZ2UgYWRzIGxheW91dC4KPiAKPiB2MjogZG9uJ3QgY2FsbCBpdCBvYmplY3QgKENocmlz
KQo+IHYzOiByZXN0eWxlIG9mZnNldCBhc3NpZ25tZW50cyAoQ2hyaXMpCj4gdjQ6IHN0eWxpc3Rp
YyByZWR1Y3Rpb25zCj4gCj4gU2lnbmVkLW9mZi1ieTogTWljaGFsIFdhamRlY3prbyA8bWljaGFs
LndhamRlY3prb0BpbnRlbC5jb20+Cj4gQ2M6IE9zY2FyIE1hdGVvIDxvc2Nhci5tYXRlb0BpbnRl
bC5jb20+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVs
LmNvbT4KPiBDYzogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlv
QGludGVsLmNvbT4KPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+
Cj4gUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+
IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgfCA1MSAr
KysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIzIGluc2Vy
dGlvbnMoKyksIDI4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X2d1Y19zdWJtaXNzaW9uLmMKPiBpbmRleCBiNGQyNGNkNzYzOWEuLjM2NTFhMWIwZDEzYyAxMDA2
NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiAr
KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiBAQCAtODA2
LDI2ICs4MDYsMjcgQEAgc3RhdGljIHZvaWQgZ3VjX3BvbGljaWVzX2luaXQoc3RydWN0IGd1Y19w
b2xpY2llcyAqcG9saWNpZXMpCj4gIAlwb2xpY2llcy0+aXNfdmFsaWQgPSAxOwo+ICB9Cj4gIAo+
ICsjZGVmaW5lIHBfb2Zmc2V0KHB0ciwgbWVtYmVyKSBvZmZzZXRvZih0eXBlb2YoKnB0ciksIG1l
bWJlcikKPiArCgpJIHdvdWxkIHBsYWNlIHRoaXMgaGVscGVyIG1hY3JvIGluIGk5MTVfdXRpbHMu
aCA7KQoKLU1pY2hhbAoKPiAgc3RhdGljIHZvaWQgZ3VjX2FkZG9uX2NyZWF0ZShzdHJ1Y3QgaW50
ZWxfZ3VjICpndWMpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9
IGd1Y190b19pOTE1KGd1Yyk7Cj4gIAlzdHJ1Y3QgaTkxNV92bWEgKnZtYTsKPiAtCXN0cnVjdCBn
dWNfYWRzICphZHM7Cj4gLQlzdHJ1Y3QgZ3VjX3BvbGljaWVzICpwb2xpY2llczsKPiAtCXN0cnVj
dCBndWNfbW1pb19yZWdfc3RhdGUgKnJlZ19zdGF0ZTsKPiAtCXN0cnVjdCBpbnRlbF9lbmdpbmVf
Y3MgKmVuZ2luZTsKPiAtCWVudW0gaW50ZWxfZW5naW5lX2lkIGlkOwo+ICAJc3RydWN0IHBhZ2Ug
KnBhZ2U7Cj4gLQl1MzIgc2l6ZTsKPiAtCj4gIAkvKiBUaGUgYWRzIG9iaiBpbmNsdWRlcyB0aGUg
c3RydWN0IGl0c2VsZiBhbmQgYnVmZmVycyBwYXNzZWQgdG8gR3VDICovCj4gLQlzaXplID0gc2l6
ZW9mKHN0cnVjdCBndWNfYWRzKSArIHNpemVvZihzdHJ1Y3QgZ3VjX3BvbGljaWVzKSArCj4gLQkJ
CXNpemVvZihzdHJ1Y3QgZ3VjX21taW9fcmVnX3N0YXRlKSArCj4gLQkJCUdVQ19TM19TQVZFX1NQ
QUNFX1BBR0VTICogUEFHRV9TSVpFOwo+ICsJc3RydWN0IHsKPiArCQlzdHJ1Y3QgZ3VjX2FkcyBh
ZHM7Cj4gKwkJc3RydWN0IGd1Y19wb2xpY2llcyBwb2xpY2llczsKPiArCQlzdHJ1Y3QgZ3VjX21t
aW9fcmVnX3N0YXRlIHJlZ19zdGF0ZTsKPiArCQl1OCByZWdfc3RhdGVfYnVmZmVyW0dVQ19TM19T
QVZFX1NQQUNFX1BBR0VTICogUEFHRV9TSVpFXTsKPiArCX0gX19wYWNrZWQgKmJsb2I7Cj4gKwl1
MzIgb2Zmc2V0Owo+ICsJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+ICsJZW51bSBp
bnRlbF9lbmdpbmVfaWQgaWQ7Cj4gIAo+ICAJdm1hID0gZ3VjLT5hZHNfdm1hOwo+ICAJaWYgKCF2
bWEpIHsKPiAtCQl2bWEgPSBpbnRlbF9ndWNfYWxsb2NhdGVfdm1hKGd1YywgUEFHRV9BTElHTihz
aXplKSk7Cj4gKwkJdm1hID0gaW50ZWxfZ3VjX2FsbG9jYXRlX3ZtYShndWMsIFBBR0VfQUxJR04o
c2l6ZW9mKCpibG9iKSkpOwo+ICAJCWlmIChJU19FUlIodm1hKSkKPiAgCQkJcmV0dXJuOwo+ICAK
PiBAQCAtODMzLDcgKzgzNCw4IEBAIHN0YXRpYyB2b2lkIGd1Y19hZGRvbl9jcmVhdGUoc3RydWN0
IGludGVsX2d1YyAqZ3VjKQo+ICAJfQo+ICAKPiAgCXBhZ2UgPSBpOTE1X3ZtYV9maXJzdF9wYWdl
KHZtYSk7Cj4gLQlhZHMgPSBrbWFwKHBhZ2UpOwo+ICsJYmxvYiA9IGttYXAocGFnZSk7Cj4gKwlv
ZmZzZXQgPSBpOTE1X2dndHRfb2Zmc2V0KHZtYSk7Cj4gIAo+ICAJLyoKPiAgCSAqIFRoZSBHdUMg
cmVxdWlyZXMgYSAiR29sZGVuIENvbnRleHQiIHdoZW4gaXQgcmVpbml0aWFsaXNlcwo+IEBAIC04
NDMsMzQgKzg0NSwyNyBAQCBzdGF0aWMgdm9pZCBndWNfYWRkb25fY3JlYXRlKHN0cnVjdCBpbnRl
bF9ndWMgKmd1YykKPiAgCSAqIHRvIGZpbmQgaXQuCj4gIAkgKi8KPiAgCWVuZ2luZSA9IGRldl9w
cml2LT5lbmdpbmVbUkNTXTsKPiAtCWFkcy0+Z29sZGVuX2NvbnRleHRfbHJjYSA9IGVuZ2luZS0+
c3RhdHVzX3BhZ2UuZ2d0dF9vZmZzZXQ7Cj4gKwlibG9iLT5hZHMuZ29sZGVuX2NvbnRleHRfbHJj
YSA9IGVuZ2luZS0+c3RhdHVzX3BhZ2UuZ2d0dF9vZmZzZXQ7Cj4gIAo+ICAJZm9yX2VhY2hfZW5n
aW5lKGVuZ2luZSwgZGV2X3ByaXYsIGlkKQo+IC0JCWFkcy0+ZW5nX3N0YXRlX3NpemVbZW5naW5l
LT5ndWNfaWRdID0gaW50ZWxfbHJfY29udGV4dF9zaXplKGVuZ2luZSk7Cj4gKwkJYmxvYi0+YWRz
LmVuZ19zdGF0ZV9zaXplW2VuZ2luZS0+Z3VjX2lkXSA9Cj4gKwkJCWludGVsX2xyX2NvbnRleHRf
c2l6ZShlbmdpbmUpOwo+ICAKPiAgCS8qIEd1QyBzY2hlZHVsaW5nIHBvbGljaWVzICovCj4gLQlw
b2xpY2llcyA9ICh2b2lkICopYWRzICsgc2l6ZW9mKHN0cnVjdCBndWNfYWRzKTsKPiAtCWd1Y19w
b2xpY2llc19pbml0KHBvbGljaWVzKTsKPiAtCj4gLQlhZHMtPnNjaGVkdWxlcl9wb2xpY2llcyA9
Cj4gLQkJZ3VjX2dndHRfb2Zmc2V0KHZtYSkgKyBzaXplb2Yoc3RydWN0IGd1Y19hZHMpOwo+ICsJ
Z3VjX3BvbGljaWVzX2luaXQoJmJsb2ItPnBvbGljaWVzKTsKPiAgCj4gIAkvKiBNTUlPIHJlZyBz
dGF0ZSAqLwo+IC0JcmVnX3N0YXRlID0gKHZvaWQgKilwb2xpY2llcyArIHNpemVvZihzdHJ1Y3Qg
Z3VjX3BvbGljaWVzKTsKPiAtCj4gIAlmb3JfZWFjaF9lbmdpbmUoZW5naW5lLCBkZXZfcHJpdiwg
aWQpIHsKPiAtCQlyZWdfc3RhdGUtPm1taW9fd2hpdGVfbGlzdFtlbmdpbmUtPmd1Y19pZF0ubW1p
b19zdGFydCA9Cj4gKwkJYmxvYi0+cmVnX3N0YXRlLm1taW9fd2hpdGVfbGlzdFtlbmdpbmUtPmd1
Y19pZF0ubW1pb19zdGFydCA9Cj4gIAkJCWVuZ2luZS0+bW1pb19iYXNlICsgR1VDX01NSU9fV0hJ
VEVfTElTVF9TVEFSVDsKPiAgCj4gIAkJLyogTm90aGluZyB0byBiZSBzYXZlZCBvciByZXN0b3Jl
ZCBmb3Igbm93LiAqLwo+IC0JCXJlZ19zdGF0ZS0+bW1pb193aGl0ZV9saXN0W2VuZ2luZS0+Z3Vj
X2lkXS5jb3VudCA9IDA7Cj4gKwkJYmxvYi0+cmVnX3N0YXRlLm1taW9fd2hpdGVfbGlzdFtlbmdp
bmUtPmd1Y19pZF0uY291bnQgPSAwOwo+ICAJfQo+ICAKPiAtCWFkcy0+cmVnX3N0YXRlX2FkZHIg
PSBhZHMtPnNjaGVkdWxlcl9wb2xpY2llcyArCj4gLQkJCXNpemVvZihzdHJ1Y3QgZ3VjX3BvbGlj
aWVzKTsKPiAtCj4gLQlhZHMtPnJlZ19zdGF0ZV9idWZmZXIgPSBhZHMtPnJlZ19zdGF0ZV9hZGRy
ICsKPiAtCQkJc2l6ZW9mKHN0cnVjdCBndWNfbW1pb19yZWdfc3RhdGUpOwo+ICsJYmxvYi0+YWRz
LnNjaGVkdWxlcl9wb2xpY2llcyA9IG9mZnNldCArIHBfb2Zmc2V0KGJsb2IsIHBvbGljaWVzKTsK
PiArCWJsb2ItPmFkcy5yZWdfc3RhdGVfYWRkciA9IG9mZnNldCArIHBfb2Zmc2V0KGJsb2IsIHJl
Z19zdGF0ZSk7Cj4gKwlibG9iLT5hZHMucmVnX3N0YXRlX2J1ZmZlciA9IG9mZnNldCArIHBfb2Zm
c2V0KGJsb2IsIHJlZ19zdGF0ZV9idWZmZXIpOwo+ICAKPiAgCWt1bm1hcChwYWdlKTsKPiAgfQo+
IC0tIAo+IDIuMTEuMAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv
cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl
bC1nZngK