From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753758AbdCONVr (ORCPT ); Wed, 15 Mar 2017 09:21:47 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:35277 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753697AbdCONVp (ORCPT ); Wed, 15 Mar 2017 09:21:45 -0400 Date: Wed, 15 Mar 2017 14:21:42 +0100 From: Boris Brezillon To: Lee Jones Cc: Nicolas Ferre , Alexandre Belloni , linux-arm-kernel@lists.infradead.org, Samuel Ortiz , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation Message-ID: <20170315142142.124b9693@bbrezillon> In-Reply-To: <20170315121948.ys63ntordjwcm6rb@dell> References: <1487609701-10300-1-git-send-email-boris.brezillon@free-electrons.com> <1487609701-10300-2-git-send-email-boris.brezillon@free-electrons.com> <20170314170003.nfpc7adtyczvhb26@dell> <20170314182117.4c6c2162@bbrezillon> <20170315121948.ys63ntordjwcm6rb@dell> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Mar 2017 12:19:48 +0000 Lee Jones wrote: > On Tue, 14 Mar 2017, Boris Brezillon wrote: > > > On Tue, 14 Mar 2017 17:00:03 +0000 > > Lee Jones wrote: > > > > > On Mon, 20 Feb 2017, Boris Brezillon wrote: > > > > > > > These new helpers + macro definitions are meant to replace the old ones > > > > which are unpractical to use. > > > > > > > > Note that the macros and function prefixes have been intentionally > > > > changed to ATMEL_[H]SMC_XX and atmel_[h]smc_ to reflect the fact that > > > > this IP is also embedded in avr32 SoCs (and not only in at91 ones). > > > > > > I'm going to NACK this patch. > > > > > > I don't see any reason why all those functions have to be inline and > > > shoved into a header file. > > > > Because those are simple conversion helpers, and I thought a > > dedicated C file was not required, but I can move them into a C file > > and export these functions using EXPORT_SYMBOL_GPL() if you prefer. > > > > Would that work for you? > > I think that would be better TBH. Those functions aren't all that > simple. There is certainly too much meat on the bones for me to be > happy for them to be shoved into a header file. > I'm fine with that. Are you okay if I put this code in drivers/mfd/atmel-smc.c? From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Wed, 15 Mar 2017 14:21:42 +0100 Subject: [PATCH 1/7] mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation In-Reply-To: <20170315121948.ys63ntordjwcm6rb@dell> References: <1487609701-10300-1-git-send-email-boris.brezillon@free-electrons.com> <1487609701-10300-2-git-send-email-boris.brezillon@free-electrons.com> <20170314170003.nfpc7adtyczvhb26@dell> <20170314182117.4c6c2162@bbrezillon> <20170315121948.ys63ntordjwcm6rb@dell> Message-ID: <20170315142142.124b9693@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 15 Mar 2017 12:19:48 +0000 Lee Jones wrote: > On Tue, 14 Mar 2017, Boris Brezillon wrote: > > > On Tue, 14 Mar 2017 17:00:03 +0000 > > Lee Jones wrote: > > > > > On Mon, 20 Feb 2017, Boris Brezillon wrote: > > > > > > > These new helpers + macro definitions are meant to replace the old ones > > > > which are unpractical to use. > > > > > > > > Note that the macros and function prefixes have been intentionally > > > > changed to ATMEL_[H]SMC_XX and atmel_[h]smc_ to reflect the fact that > > > > this IP is also embedded in avr32 SoCs (and not only in at91 ones). > > > > > > I'm going to NACK this patch. > > > > > > I don't see any reason why all those functions have to be inline and > > > shoved into a header file. > > > > Because those are simple conversion helpers, and I thought a > > dedicated C file was not required, but I can move them into a C file > > and export these functions using EXPORT_SYMBOL_GPL() if you prefer. > > > > Would that work for you? > > I think that would be better TBH. Those functions aren't all that > simple. There is certainly too much meat on the bones for me to be > happy for them to be shoved into a header file. > I'm fine with that. Are you okay if I put this code in drivers/mfd/atmel-smc.c?