Re: [RFC v1 for accelerated IPoIB 04/25] IB/verb: Add ipoib_options struct and API

["Vishwanathapura, Niranjana" <niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Wed, Mar 15, 2017 at 08:27:28AM +0200, Leon Romanovsky wrote:
>On Tue, Mar 14, 2017 at 12:03:01PM -0700, Vishwanathapura, Niranjana wrote:
>> On Tue, Mar 14, 2017 at 03:25:01PM +0200, Erez Shitrit wrote:
>> > On Mon, Mar 13, 2017 at 10:01 PM, Jason Gunthorpe
>> > <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
>> > > On Mon, Mar 13, 2017 at 08:31:15PM +0200, Erez Shitrit wrote:
>> > >
>> > > > diff --git a/include/rdma/ib_ipoib_accel_ops.h b/include/rdma/ib_ipoib_accel_ops.h
>> > > > new file mode 100644
>> > > > index 000000000000..148a5529a559
>> > > > +++ b/include/rdma/ib_ipoib_accel_ops.h
>> > >
>> > > Both patches need a better naming scheme for this file..
>> > >
>> > > rn_opa_vnic.h
>> > > rn_ipoib.h
>> > >
>> > > Maybe?
>> >
>> > Can work for me.
>> >
>> > vnic?
>> >
>>
>> I do see why it is an issue for ipoib (we don't want two ipoib.h files). We
>> can add rn_ prefix for vnic, but probably opa_vnic.h is good enough.
>
>Just for the consistency, I would like to see the same "rn_" prefix
>for both files (ipoib and opa_vnic).
>
>Thanks

Fine with VNIC.

Niranjana

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html