From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] dt-bindings: rng: clocks property on omap_rng is optional Date: Wed, 15 Mar 2017 12:57:37 -0500 Message-ID: <20170315175737.vfy5omissjkyyie7@rob-hp-laptop> References: <1488896308-17731-1-git-send-email-thomas.petazzoni@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ian Campbell , Pawel Moll , Mark Rutland , Kumar Gala , Deepak Saxena , Matt Mackall , Herbert Xu , linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, romain.perier-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Nadav Haklai , Hanna Hawa , Yehuda Yitschak , stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thomas Petazzoni Return-path: Content-Disposition: inline In-Reply-To: <1488896308-17731-1-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org On Tue, Mar 07, 2017 at 03:18:28PM +0100, Thomas Petazzoni wrote: > Commit 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 > device variant") update the omap_rng Device Tree binding to add support > for the IP-76 variation of the IP. As part of this change, a "clocks" > property was added, but is indicated as "Required", while it is in fact > "Optional": some SoCs do not require a clock for this IP block. > > Fixes: 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 device variant") > Cc: > Signed-off-by: Thomas Petazzoni > --- > Documentation/devicetree/bindings/rng/omap_rng.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rng/omap_rng.txt b/Documentation/devicetree/bindings/rng/omap_rng.txt > index 4714772..20d435da 100644 > --- a/Documentation/devicetree/bindings/rng/omap_rng.txt > +++ b/Documentation/devicetree/bindings/rng/omap_rng.txt > @@ -12,6 +12,9 @@ Required properties: > - reg : Offset and length of the register set for the module > - interrupts : the interrupt number for the RNG module. > Used for "ti,omap4-rng" and "inside-secure,safexcel-eip76" > + > +Optional properties: > + Wouldn't just "for ? compatible only" be more correct? > - clocks: the trng clock source > > Example: > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:35869 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbdCOR5k (ORCPT ); Wed, 15 Mar 2017 13:57:40 -0400 Date: Wed, 15 Mar 2017 12:57:37 -0500 From: Rob Herring To: Thomas Petazzoni Cc: devicetree@vger.kernel.org, Ian Campbell , Pawel Moll , Mark Rutland , Kumar Gala , Deepak Saxena , Matt Mackall , Herbert Xu , linux-crypto@vger.kernel.org, romain.perier@collabora.com, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Nadav Haklai , Hanna Hawa , Yehuda Yitschak , stable@vger.kernel.org Subject: Re: [PATCH] dt-bindings: rng: clocks property on omap_rng is optional Message-ID: <20170315175737.vfy5omissjkyyie7@rob-hp-laptop> References: <1488896308-17731-1-git-send-email-thomas.petazzoni@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488896308-17731-1-git-send-email-thomas.petazzoni@free-electrons.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Mar 07, 2017 at 03:18:28PM +0100, Thomas Petazzoni wrote: > Commit 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 > device variant") update the omap_rng Device Tree binding to add support > for the IP-76 variation of the IP. As part of this change, a "clocks" > property was added, but is indicated as "Required", while it is in fact > "Optional": some SoCs do not require a clock for this IP block. > > Fixes: 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 device variant") > Cc: > Signed-off-by: Thomas Petazzoni > --- > Documentation/devicetree/bindings/rng/omap_rng.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rng/omap_rng.txt b/Documentation/devicetree/bindings/rng/omap_rng.txt > index 4714772..20d435da 100644 > --- a/Documentation/devicetree/bindings/rng/omap_rng.txt > +++ b/Documentation/devicetree/bindings/rng/omap_rng.txt > @@ -12,6 +12,9 @@ Required properties: > - reg : Offset and length of the register set for the module > - interrupts : the interrupt number for the RNG module. > Used for "ti,omap4-rng" and "inside-secure,safexcel-eip76" > + > +Optional properties: > + Wouldn't just "for ? compatible only" be more correct? > - clocks: the trng clock source > > Example: > -- > 2.7.4 >