All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tpm: select CONFIG_CRYPTO
@ 2017-03-14 21:40 ` Arnd Bergmann
  0 siblings, 0 replies; 11+ messages in thread
From: Arnd Bergmann @ 2017-03-14 21:40 UTC (permalink / raw)
  To: Peter Huewe, Marcel Selhorst, Jarkko Sakkinen
  Cc: Arnd Bergmann, Jason Gunthorpe, Stefan Berger, Christophe Ricard,
	Nayna Jain, tpmdd-devel, linux-kernel

As we need the CRYPTO_HASH_INFO implementation, we should also
select CRYPTO itself to avoid this build warning:

warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)

Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/tpm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index af985cca413c..d520ac51c11c 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -6,6 +6,7 @@ menuconfig TCG_TPM
 	tristate "TPM Hardware Support"
 	depends on HAS_IOMEM
 	select SECURITYFS
+	select CRYPTO
 	select CRYPTO_HASH_INFO
 	---help---
 	  If you have a TPM security chip in your system, which
-- 
2.9.0

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH] tpm: select CONFIG_CRYPTO
@ 2017-02-28 21:12 Arnd Bergmann
  2017-02-28 21:24   ` Peter Huewe
  0 siblings, 1 reply; 11+ messages in thread
From: Arnd Bergmann @ 2017-02-28 21:12 UTC (permalink / raw)
  To: Peter Huewe, Marcel Selhorst, Jarkko Sakkinen
  Cc: Arnd Bergmann, Jason Gunthorpe, Stefan Berger, Christophe Ricard,
	Nayna Jain, tpmdd-devel, linux-kernel

We get a newly introduced harmless warning when CONFIG_CRYPTO is disabled:

warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)

This adds another select to avoid the warning, consistent with other users
of the crypto code.

Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/tpm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index af985cca413c..d520ac51c11c 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -6,6 +6,7 @@ menuconfig TCG_TPM
 	tristate "TPM Hardware Support"
 	depends on HAS_IOMEM
 	select SECURITYFS
+	select CRYPTO
 	select CRYPTO_HASH_INFO
 	---help---
 	  If you have a TPM security chip in your system, which
-- 
2.9.0

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2017-03-15 17:58 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-14 21:40 [PATCH] tpm: select CONFIG_CRYPTO Arnd Bergmann
2017-03-14 21:40 ` Arnd Bergmann
2017-03-15  8:30 ` Jarkko Sakkinen
2017-03-15 11:39   ` Arnd Bergmann
2017-03-15 11:39     ` Arnd Bergmann
2017-03-15 17:58     ` Jarkko Sakkinen
  -- strict thread matches above, loose matches on Subject: below --
2017-02-28 21:12 Arnd Bergmann
2017-02-28 21:24 ` Peter Huewe
2017-02-28 21:24   ` Peter Huewe
2017-03-02  9:17   ` Jarkko Sakkinen
2017-03-02  9:17     ` Jarkko Sakkinen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.