From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752644AbdCOTcZ (ORCPT ); Wed, 15 Mar 2017 15:32:25 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35763 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751198AbdCOTcY (ORCPT ); Wed, 15 Mar 2017 15:32:24 -0400 Date: Wed, 15 Mar 2017 14:29:28 -0500 From: Rob Herring To: Jonathan Cameron Cc: Fabrice Gasnier , linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, mark.rutland@arm.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, lars@metafoo.de, knaack.h@gmx.de, pmeerw@pmeerw.net, benjamin.gaignard@linaro.org, benjamin.gaignard@st.com, linus.walleij@linaro.org Subject: Re: [PATCH v3 3/6] dt-bindings: iio: document interrupt trigger support Message-ID: <20170315192928.p35tsixaokqxulwq@rob-hp-laptop> References: <1488300679-3259-1-git-send-email-fabrice.gasnier@st.com> <1488300679-3259-4-git-send-email-fabrice.gasnier@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 05, 2017 at 12:16:28PM +0000, Jonathan Cameron wrote: > On 28/02/17 16:51, Fabrice Gasnier wrote: > > Document interrupt trigger that takes a generic interrupt, and > > can be used as trigger source for sampling devices such as sensors, > > ADCs... > > > > Signed-off-by: Fabrice Gasnier > I'm not convinced we want the earlier device tree binding doc at all. > In the vast majority of cases that chunk on providers is irrelevant. > What matters is to document the specific case as you have done here. > > So this one I like, the earlier document less so, simply because > it repeats what this more specific document has described. > > So Rob, what do you think of 'just' this bit? Yeah, it seems fine. Though, the #io-trigger-cells can be dropped. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 3/6] dt-bindings: iio: document interrupt trigger support Date: Wed, 15 Mar 2017 14:29:28 -0500 Message-ID: <20170315192928.p35tsixaokqxulwq@rob-hp-laptop> References: <1488300679-3259-1-git-send-email-fabrice.gasnier@st.com> <1488300679-3259-4-git-send-email-fabrice.gasnier@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jonathan Cameron Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, benjamin.gaignard@linaro.org, lars@metafoo.de, alexandre.torgue@st.com, linux-iio@vger.kernel.org, pmeerw@pmeerw.net, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, mcoquelin.stm32@gmail.com, knaack.h@gmx.de, Fabrice Gasnier , linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, benjamin.gaignard@st.com List-Id: devicetree@vger.kernel.org On Sun, Mar 05, 2017 at 12:16:28PM +0000, Jonathan Cameron wrote: > On 28/02/17 16:51, Fabrice Gasnier wrote: > > Document interrupt trigger that takes a generic interrupt, and > > can be used as trigger source for sampling devices such as sensors, > > ADCs... > > > > Signed-off-by: Fabrice Gasnier > I'm not convinced we want the earlier device tree binding doc at all. > In the vast majority of cases that chunk on providers is irrelevant. > What matters is to document the specific case as you have done here. > > So this one I like, the earlier document less so, simply because > it repeats what this more specific document has described. > > So Rob, what do you think of 'just' this bit? Yeah, it seems fine. Though, the #io-trigger-cells can be dropped. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Wed, 15 Mar 2017 14:29:28 -0500 Subject: [PATCH v3 3/6] dt-bindings: iio: document interrupt trigger support In-Reply-To: References: <1488300679-3259-1-git-send-email-fabrice.gasnier@st.com> <1488300679-3259-4-git-send-email-fabrice.gasnier@st.com> Message-ID: <20170315192928.p35tsixaokqxulwq@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Mar 05, 2017 at 12:16:28PM +0000, Jonathan Cameron wrote: > On 28/02/17 16:51, Fabrice Gasnier wrote: > > Document interrupt trigger that takes a generic interrupt, and > > can be used as trigger source for sampling devices such as sensors, > > ADCs... > > > > Signed-off-by: Fabrice Gasnier > I'm not convinced we want the earlier device tree binding doc at all. > In the vast majority of cases that chunk on providers is irrelevant. > What matters is to document the specific case as you have done here. > > So this one I like, the earlier document less so, simply because > it repeats what this more specific document has described. > > So Rob, what do you think of 'just' this bit? Yeah, it seems fine. Though, the #io-trigger-cells can be dropped. Rob