From: Okash Khawaja <okash.khawaja@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Kirk Reiser <kirk@reisers.ca>,
speakup@linux-speakup.org, Chris Brannon <chris@the-brannons.com>
Subject: Re: [patch 4/4] staging: speakup: move those functions which do outgoing serial comms, into serialio.c
Date: Thu, 16 Mar 2017 06:51:54 +0000 [thread overview]
Message-ID: <20170316065154.GA756@sanghar> (raw)
In-Reply-To: <20170316021409.GA26547@kroah.com>
On Thu, Mar 16, 2017 at 11:14:09AM +0900, Greg Kroah-Hartman wrote:
> On Tue, Mar 14, 2017 at 01:41:55PM +0000, Okash Khawaja wrote:
> > This moves spk_synth_immediate and spk_serial_synth_probe functions into
> > serialio.c. These functions do outgoing serial comms. The move is a step
> > towards collecting all serial comms in serialio.c. This also renames
> > spk_synth_immediate to spk_serial_synth_immediate.
> >
> > Code inside those functions has not been changed. Along the way, this patch
> > also fixes a couple of spots which were calling spk_synth_immediate directly,
> > so that the calls now happen via the spk_syth struct.
> >
> > Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
> > Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> >
> > Index: linux-4.11-rc2/drivers/staging/speakup/serialio.c
>
> This patch doesn't apply to my tree at all. The first 3 applied with
> some fuzz, so I think you are not working against linux-next. Please
> rebase your patch against linux-next, or my staging-testing branch, and
> resend so I can apply it.
Sure, will rebase against staging-testing. Just this patch or the
patch set?
next prev parent reply other threads:[~2017-03-16 6:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 13:41 [patch 0/4] staging: speakup: refactor to make raw serial i/o swappable Okash Khawaja
2017-03-14 13:41 ` [patch 1/4] staging: speakup: spk_serial_out and spk_wait_for_xmitr to take synth arg Okash Khawaja
2017-03-14 13:41 ` [patch 2/4] staging: serial: add spk_io_ops struct to spk_synth Okash Khawaja
2017-03-14 13:41 ` [patch 3/4] staging: speakup: move spk_stop_serial_interrupt into synth-specific release function Okash Khawaja
2017-03-14 13:41 ` [patch 4/4] staging: speakup: move those functions which do outgoing serial comms, into serialio.c Okash Khawaja
2017-03-16 2:14 ` Greg Kroah-Hartman
2017-03-16 6:51 ` Okash Khawaja [this message]
2017-03-16 7:01 ` Greg Kroah-Hartman
2017-03-16 8:10 ` Okash Khawaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316065154.GA756@sanghar \
--to=okash.khawaja@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.