From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752465AbdCPM17 (ORCPT ); Thu, 16 Mar 2017 08:27:59 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:43106 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbdCPM14 (ORCPT ); Thu, 16 Mar 2017 08:27:56 -0400 From: Vignesh R To: Greg Kroah-Hartman CC: Jiri Slaby , , , , Vignesh R , Andy Shevchenko , Jisheng Zhang Subject: [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq Date: Thu, 16 Mar 2017 17:56:53 +0530 Message-ID: <20170316122653.19930-1-vigneshr@ti.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using dev_name() as irq name during request_irq() might be misleading in case of serial over PCI. Therefore use a better alternative name for identifying serial port irqs as "serial" appended with serial_index of the port. This ensures that "serial" string is always present in irq name while port index will help in distinguishing b/w different ports. Signed-off-by: Vignesh R --- Based on top of tty-next. drivers/tty/serial/8250/8250_core.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index f83b69f30987..78bf621d6827 100644 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c @@ -213,12 +213,20 @@ static int serial_link_irq_chain(struct uart_8250_port *up) ret = 0; } else { + char *irqname = kmalloc(20, GFP_KERNEL); + if (!irqname) { + spin_unlock_irq(&i->lock); + return -ENOMEM; + } + snprintf(irqname, 20, + "serial%d", serial_index(&up->port)); + INIT_LIST_HEAD(&up->list); i->head = &up->list; spin_unlock_irq(&i->lock); irq_flags |= up->port.irqflags; ret = request_irq(up->port.irq, serial8250_interrupt, - irq_flags, dev_name(up->port.dev), i); + irq_flags, irqname, i); if (ret < 0) serial_do_unlink(i, up); } -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vignesh R Subject: [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq Date: Thu, 16 Mar 2017 17:56:53 +0530 Message-ID: <20170316122653.19930-1-vigneshr@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Greg Kroah-Hartman Cc: Jisheng Zhang , Vignesh R , linux-kernel@vger.kernel.org, Andy Shevchenko , linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org List-Id: linux-serial@vger.kernel.org Using dev_name() as irq name during request_irq() might be misleading in case of serial over PCI. Therefore use a better alternative name for identifying serial port irqs as "serial" appended with serial_index of the port. This ensures that "serial" string is always present in irq name while port index will help in distinguishing b/w different ports. Signed-off-by: Vignesh R --- Based on top of tty-next. drivers/tty/serial/8250/8250_core.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index f83b69f30987..78bf621d6827 100644 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c @@ -213,12 +213,20 @@ static int serial_link_irq_chain(struct uart_8250_port *up) ret = 0; } else { + char *irqname = kmalloc(20, GFP_KERNEL); + if (!irqname) { + spin_unlock_irq(&i->lock); + return -ENOMEM; + } + snprintf(irqname, 20, + "serial%d", serial_index(&up->port)); + INIT_LIST_HEAD(&up->list); i->head = &up->list; spin_unlock_irq(&i->lock); irq_flags |= up->port.irqflags; ret = request_irq(up->port.irq, serial8250_interrupt, - irq_flags, dev_name(up->port.dev), i); + irq_flags, irqname, i); if (ret < 0) serial_do_unlink(i, up); } -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: vigneshr@ti.com (Vignesh R) Date: Thu, 16 Mar 2017 17:56:53 +0530 Subject: [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq Message-ID: <20170316122653.19930-1-vigneshr@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Using dev_name() as irq name during request_irq() might be misleading in case of serial over PCI. Therefore use a better alternative name for identifying serial port irqs as "serial" appended with serial_index of the port. This ensures that "serial" string is always present in irq name while port index will help in distinguishing b/w different ports. Signed-off-by: Vignesh R --- Based on top of tty-next. drivers/tty/serial/8250/8250_core.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index f83b69f30987..78bf621d6827 100644 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c @@ -213,12 +213,20 @@ static int serial_link_irq_chain(struct uart_8250_port *up) ret = 0; } else { + char *irqname = kmalloc(20, GFP_KERNEL); + if (!irqname) { + spin_unlock_irq(&i->lock); + return -ENOMEM; + } + snprintf(irqname, 20, + "serial%d", serial_index(&up->port)); + INIT_LIST_HEAD(&up->list); i->head = &up->list; spin_unlock_irq(&i->lock); irq_flags |= up->port.irqflags; ret = request_irq(up->port.irq, serial8250_interrupt, - irq_flags, dev_name(up->port.dev), i); + irq_flags, irqname, i); if (ret < 0) serial_do_unlink(i, up); } -- 2.11.0