From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752496AbdCPNgu (ORCPT ); Thu, 16 Mar 2017 09:36:50 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:53356 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752327AbdCPNgs (ORCPT ); Thu, 16 Mar 2017 09:36:48 -0400 Date: Thu, 16 Mar 2017 13:36:32 +0000 From: Russell King - ARM Linux To: Vignesh R Cc: Greg Kroah-Hartman , Jisheng Zhang , linux-kernel@vger.kernel.org, Andy Shevchenko , linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq Message-ID: <20170316133632.GV21222@n2100.armlinux.org.uk> References: <20170316122653.19930-1-vigneshr@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170316122653.19930-1-vigneshr@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 16, 2017 at 05:56:53PM +0530, Vignesh R wrote: > Using dev_name() as irq name during request_irq() might be misleading in > case of serial over PCI. Therefore use a better alternative name for > identifying serial port irqs as "serial" appended with serial_index of > the port. This ensures that "serial" string is always present in irq > name while port index will help in distinguishing b/w different ports. Wouldn't it be better to use the device name (iow, ttySx) rather than "serialx" ? Maybe a helper function in serial_core.c to format the device name into a supplied string, which can be re-used elsewhere, eg, uart_report_port() and uart_suspend_port(). IOW: const char *uart_port_name(char *buf, size_t n, struct uart_driver *drv, struct uart_port *port) { snprintf(buf, n, "%s%d", drv->dev_name, drv->tty_driver->name_base + port->line); return buf; } which means you can do this: char name[16]; request_irq(..., uart_port_name(name, sizeof(name), driver, port), ...) which also avoids the allocation. 8250 device names are always "ttyS" plus a number, so 16 characters (including NULL terminator) should be more than sufficient, and that's most likely true of all serial drivers. (The longest device name I'm aware of is ttyAMA plus a small integer for PL011 ports.) -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Thu, 16 Mar 2017 13:36:32 +0000 Subject: [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq In-Reply-To: <20170316122653.19930-1-vigneshr@ti.com> References: <20170316122653.19930-1-vigneshr@ti.com> Message-ID: <20170316133632.GV21222@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Mar 16, 2017 at 05:56:53PM +0530, Vignesh R wrote: > Using dev_name() as irq name during request_irq() might be misleading in > case of serial over PCI. Therefore use a better alternative name for > identifying serial port irqs as "serial" appended with serial_index of > the port. This ensures that "serial" string is always present in irq > name while port index will help in distinguishing b/w different ports. Wouldn't it be better to use the device name (iow, ttySx) rather than "serialx" ? Maybe a helper function in serial_core.c to format the device name into a supplied string, which can be re-used elsewhere, eg, uart_report_port() and uart_suspend_port(). IOW: const char *uart_port_name(char *buf, size_t n, struct uart_driver *drv, struct uart_port *port) { snprintf(buf, n, "%s%d", drv->dev_name, drv->tty_driver->name_base + port->line); return buf; } which means you can do this: char name[16]; request_irq(..., uart_port_name(name, sizeof(name), driver, port), ...) which also avoids the allocation. 8250 device names are always "ttyS" plus a number, so 16 characters (including NULL terminator) should be more than sufficient, and that's most likely true of all serial drivers. (The longest device name I'm aware of is ttyAMA plus a small integer for PL011 ports.) -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.