From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754280AbdCPVg1 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 17:36:27 -0400
Received: from mail.kernel.org ([198.145.29.136]:57612 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752193AbdCPVgX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 17:36:23 -0400
Date: Thu, 16 Mar 2017 17:25:35 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 5/5 v3] ftrace/x86-32: Add -mfentry support to x86_32
 with DYNAMIC_FTRACE set
Message-ID: <20170316172535.039e2fdc@gandalf.local.home>
In-Reply-To: <20170316210043.peycxdxktwwn6cid@treble>
References: <20170316172008.086705006@goodmis.org>
        <20170316172056.740347781@goodmis.org>
        <20170316164036.02fb6ec7@gandalf.local.home>
        <20170316210043.peycxdxktwwn6cid@treble>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 16 Mar 2017 16:00:43 -0500
Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> On Thu, Mar 16, 2017 at 04:40:36PM -0400, Steven Rostedt wrote:
> > [
> >   Fengguang Wu's bot told me that it failed to compile, as ftrace_32.S
> >   always gets compiled (as does ftrace_64.S). And the content needs to
> >   be protected within the #ifdef.
> > ]  
> 
> Why not instead make their compilation conditional in the Makefile?
> 
> Like:
> 
> obj-$(CONFIG_FUNCTION_TRACER)	+= ftrace_$(bits).o
> 

That's another patch ;-)

I just followed suit with what was already there.

I'll add a 6th patch to clean that up.

-- Steve