From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbdCQDdj (ORCPT ); Thu, 16 Mar 2017 23:33:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35742 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147AbdCQDde (ORCPT ); Thu, 16 Mar 2017 23:33:34 -0400 Date: Thu, 16 Mar 2017 20:32:53 -0700 From: Andrew Morton To: Jerome Glisse Cc: John Hubbard , Balbir Singh , linux-kernel@vger.kernel.org, linux-mm , Naoya Horiguchi , David Nellans , Evgeny Baskakov , Mark Hairgrove , Sherry Cheung , Subhash Gutti Subject: Re: [HMM 07/16] mm/migrate: new memory migration helper for use with device memory v4 Message-Id: <20170316203253.755ab6180affcfa3a7a9a1ba@linux-foundation.org> In-Reply-To: <2057035918.7910419.1489715543920.JavaMail.zimbra@redhat.com> References: <1489680335-6594-1-git-send-email-jglisse@redhat.com> <1489680335-6594-8-git-send-email-jglisse@redhat.com> <20170316160520.d03ac02474cad6d2c8eba9bc@linux-foundation.org> <94e0d115-7deb-c748-3dc2-60d6289e6551@nvidia.com> <2057035918.7910419.1489715543920.JavaMail.zimbra@redhat.com> X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.28; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Mar 2017 21:52:23 -0400 (EDT) Jerome Glisse wrote: > The original intention was for it to be 64bit only, 32bit is a dying > species and before splitting out hmm_ prefix from this code and moving > it to be generic it was behind a 64bit flag. > > If latter one someone really care about 32bit we can only move to u64 I think that's the best compromise. If someone wants this on 32-bit then they're free to get it working. That "someone" will actually be able to test it, which you clearly won't be doing! However, please do check that the impact of this patchset on 32-bit's `size vmlinux' is minimal. Preferably zero. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f72.google.com (mail-pg0-f72.google.com [74.125.83.72]) by kanga.kvack.org (Postfix) with ESMTP id 36F6E6B0038 for ; Thu, 16 Mar 2017 23:32:55 -0400 (EDT) Received: by mail-pg0-f72.google.com with SMTP id e5so123006540pgk.1 for ; Thu, 16 Mar 2017 20:32:55 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id 89si7216016pla.226.2017.03.16.20.32.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Mar 2017 20:32:54 -0700 (PDT) Date: Thu, 16 Mar 2017 20:32:53 -0700 From: Andrew Morton Subject: Re: [HMM 07/16] mm/migrate: new memory migration helper for use with device memory v4 Message-Id: <20170316203253.755ab6180affcfa3a7a9a1ba@linux-foundation.org> In-Reply-To: <2057035918.7910419.1489715543920.JavaMail.zimbra@redhat.com> References: <1489680335-6594-1-git-send-email-jglisse@redhat.com> <1489680335-6594-8-git-send-email-jglisse@redhat.com> <20170316160520.d03ac02474cad6d2c8eba9bc@linux-foundation.org> <94e0d115-7deb-c748-3dc2-60d6289e6551@nvidia.com> <2057035918.7910419.1489715543920.JavaMail.zimbra@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Jerome Glisse Cc: John Hubbard , Balbir Singh , linux-kernel@vger.kernel.org, linux-mm , Naoya Horiguchi , David Nellans , Evgeny Baskakov , Mark Hairgrove , Sherry Cheung , Subhash Gutti On Thu, 16 Mar 2017 21:52:23 -0400 (EDT) Jerome Glisse wrote: > The original intention was for it to be 64bit only, 32bit is a dying > species and before splitting out hmm_ prefix from this code and moving > it to be generic it was behind a 64bit flag. > > If latter one someone really care about 32bit we can only move to u64 I think that's the best compromise. If someone wants this on 32-bit then they're free to get it working. That "someone" will actually be able to test it, which you clearly won't be doing! However, please do check that the impact of this patchset on 32-bit's `size vmlinux' is minimal. Preferably zero. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org