From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751019AbdCQGRQ (ORCPT ); Fri, 17 Mar 2017 02:17:16 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47146 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbdCQGRP (ORCPT ); Fri, 17 Mar 2017 02:17:15 -0400 Date: Fri, 17 Mar 2017 15:16:59 +0900 From: Greg KH To: sunil.m@techveda.org Cc: dan.carpenter@oracle.com, devel@driverdev.osuosl.org, karthiknishu@yahoo.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/6] staging: rtl8192e: Fix coding style, warnings and checks Message-ID: <20170317061659.GA18373@kroah.com> References: <20170316023641.GA6084@kroah.com> <1489702341-14448-1-git-send-email-sunil.m@techveda.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489702341-14448-1-git-send-email-sunil.m@techveda.org> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 17, 2017 at 03:42:15AM +0530, sunil.m@techveda.org wrote: > From: Suniel Mahesh > > Split earlier patches into multiple commits for easy review as > suggested by Dan Carpenter. > Modified subject, description and in few patches both for > better readability as suggested by Greg KH. > Dropped two patches from the earler series, as they were not adding > significant value, suggested by Dan Carpenter. > Fixed the following issues reported by checkpatch.pl: > Block comments should align the * on each line, aligned. > Block comments use * on subsequent lines, other characters > are replaced by * . > Removed unnecessary 'out of memory' message. > Comparison's to NULL could be written '!foo' or 'foo', modified. > Replaced sizeof(struct foo) into sizeof(*ptr). > Spaces preferred around that 'operator', spacing provided. > Logical continuations should be on the previous line, modified accordingly. > Unnecessary parentheses around variables, removed. > Please use a blank line after function/struct/union/enum declarations, used. > Blank lines aren't necessary after an open brace '{' and before a > close brace '}', removed. > No space is necessary after a cast, removed. > Please don't use multiple blank lines, removed. I have no idea what all of this means :( Can you resend the full series, not just random patches in a series? I don't have any of the old ones anymore. If I have applied other patches, just send this as a sequence that is numbered properly, with all of the patches to be applied. You need to make it very easy for a maintainer to know what to do here, remember, we have no short-term memory of any previous submissions. thanks, greg k-h