From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH v4 1/3] mfd: wm831x: Add basic device tree binding Date: Fri, 17 Mar 2017 09:25:20 +0000 Message-ID: <20170317092520.GM6986@localhost.localdomain> References: <1489592384-11510-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20170316140019.eoe757vox5wrlkmu@dell> <20170316143144.GL6986@localhost.localdomain> <20170317091502.kzcrhj7vlku5mtq7@dell> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:57117 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751004AbdCQJZu (ORCPT ); Fri, 17 Mar 2017 05:25:50 -0400 Content-Disposition: inline In-Reply-To: <20170317091502.kzcrhj7vlku5mtq7@dell> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Lee Jones Cc: robh+dt@kernel.org, mark.rutland@arm.com, linus.walleij@linaro.org, gnurou@gmail.com, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com On Fri, Mar 17, 2017 at 09:15:02AM +0000, Lee Jones wrote: > On Thu, 16 Mar 2017, Charles Keepax wrote: > > > On Thu, Mar 16, 2017 at 02:00:19PM +0000, Lee Jones wrote: > > > On Wed, 15 Mar 2017, Charles Keepax wrote: > > > > + if (i2c->dev.of_node) { > > > > + const struct of_device_id *id = of_match_device(wm831x_of_match, > > > > + &i2c->dev); > > > > > > Not keen on this. Please declare the variable up with the others. > > > > > > > They are never going to be used anywhere else in the function. > > Again I can if you feel strongly but isn't it really better to > > limit the scope of the variables if they are only being used > > locally. > > I understand the motivation, but if we did that all the time, the code > would look pretty dire IMHO. > Ok I do another spin. > > > > + unsigned long of_type = (unsigned long)id->data; > > > > > > And this one. > > > > > > > + type = (enum wm831x_parent)of_type; > > > > > > Looks like you don't even need of_type. > > > > > > Just cast id->data straight into wm81x_parent. > > > > Pretty sure you will get a warning on 64-bit systems if I do > > that. > > What makes you think that? > commit 942786e6e647cef94cf96dcd836d343be55fc452 Author: Lee Jones mfd: arizona: Rid data size incompatibility warn when building for 64bit I am fairly sure an enum would get treated the same as an int by the compiler. I will try it and see. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751101AbdCQJZx (ORCPT ); Fri, 17 Mar 2017 05:25:53 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:57117 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751004AbdCQJZu (ORCPT ); Fri, 17 Mar 2017 05:25:50 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Fri, 17 Mar 2017 09:25:20 +0000 From: Charles Keepax To: Lee Jones CC: , , , , , , , Subject: Re: [PATCH v4 1/3] mfd: wm831x: Add basic device tree binding Message-ID: <20170317092520.GM6986@localhost.localdomain> References: <1489592384-11510-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20170316140019.eoe757vox5wrlkmu@dell> <20170316143144.GL6986@localhost.localdomain> <20170317091502.kzcrhj7vlku5mtq7@dell> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170317091502.kzcrhj7vlku5mtq7@dell> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703170081 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 17, 2017 at 09:15:02AM +0000, Lee Jones wrote: > On Thu, 16 Mar 2017, Charles Keepax wrote: > > > On Thu, Mar 16, 2017 at 02:00:19PM +0000, Lee Jones wrote: > > > On Wed, 15 Mar 2017, Charles Keepax wrote: > > > > + if (i2c->dev.of_node) { > > > > + const struct of_device_id *id = of_match_device(wm831x_of_match, > > > > + &i2c->dev); > > > > > > Not keen on this. Please declare the variable up with the others. > > > > > > > They are never going to be used anywhere else in the function. > > Again I can if you feel strongly but isn't it really better to > > limit the scope of the variables if they are only being used > > locally. > > I understand the motivation, but if we did that all the time, the code > would look pretty dire IMHO. > Ok I do another spin. > > > > + unsigned long of_type = (unsigned long)id->data; > > > > > > And this one. > > > > > > > + type = (enum wm831x_parent)of_type; > > > > > > Looks like you don't even need of_type. > > > > > > Just cast id->data straight into wm81x_parent. > > > > Pretty sure you will get a warning on 64-bit systems if I do > > that. > > What makes you think that? > commit 942786e6e647cef94cf96dcd836d343be55fc452 Author: Lee Jones mfd: arizona: Rid data size incompatibility warn when building for 64bit I am fairly sure an enum would get treated the same as an int by the compiler. I will try it and see. Thanks, Charles