From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/2] drm: Mark up accesses of vblank->enabled outside of
 its spinlock
Date: Fri, 17 Mar 2017 11:47:51 +0200
Message-ID: <20170317094751.GL31595@intel.com>
References: <20170316234749.1297-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20170316234749.1297-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gVGh1LCBNYXIgMTYsIDIwMTcgYXQgMTE6NDc6NDhQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IE9yZGVyIHRoZSB1cGRhdGUgdG8gdmJsYW5rLT5lbmFibGVkIGFmdGVyIHRoZSB0aW1l
c3RhbXAgaXMgcHJpbWVkIHNvCj4gdGhhdCBhIGNvbmN1cnJlbnQgdW5sb2NrZWQgcmVhZGVyIHdp
bGwgb25seSBzZWUgdGhlIHZibGFuay0+ZW5hYmxlZCB3aXRoCj4gdGhlIGN1cnJlbnQgdGltZXN0
YW1wLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29u
LmNvLnVrPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu
Y29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IC0tLQo+
ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jIHwgMzAgKysrKysrKysrKysrKysrKysrLS0tLS0t
LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMo
LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYyBiL2RyaXZlcnMv
Z3B1L2RybS9kcm1faXJxLmMKPiBpbmRleCA1M2E1MjZjN2IyNGQuLjRjYzkzNTJhYjZhOCAxMDA2
NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUv
ZHJtL2RybV9pcnEuYwo+IEBAIC0zMzYsMTAgKzMzNiw4IEBAIHN0YXRpYyB2b2lkIHZibGFua19k
aXNhYmxlX2FuZF9zYXZlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBl
KQo+ICAJICogY2FsbGluZyB0aGUgLT5kaXNhYmxlX3ZibGFuaygpIG9wZXJhdGlvbiBpbiBhdG9t
aWMgY29udGV4dCB3aXRoIHRoZQo+ICAJICogaGFyZHdhcmUgcG90ZW50aWFsbHkgcnVudGltZSBz
dXNwZW5kZWQuCj4gIAkgKi8KPiAtCWlmICh2YmxhbmstPmVuYWJsZWQpIHsKPiArCWlmIChjbXB4
Y2hnX3JlbGF4ZWQoJnZibGFuay0+ZW5hYmxlZCwgdHJ1ZSwgZmFsc2UpKQo+ICAJCV9fZGlzYWJs
ZV92YmxhbmsoZGV2LCBwaXBlKTsKPiAtCQl2YmxhbmstPmVuYWJsZWQgPSBmYWxzZTsKPiAtCX0K
PiAgCj4gIAkvKgo+ICAJICogQWx3YXlzIHVwZGF0ZSB0aGUgY291bnQgYW5kIHRpbWVzdGFtcCB0
byBtYWludGFpbiB0aGUKPiBAQCAtMzYwLDcgKzM1OCw3IEBAIHN0YXRpYyB2b2lkIHZibGFua19k
aXNhYmxlX2ZuKHVuc2lnbmVkIGxvbmcgYXJnKQo+ICAJdW5zaWduZWQgbG9uZyBpcnFmbGFnczsK
PiAgCj4gIAlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2LT52YmxfbG9jaywgaXJxZmxhZ3MpOwo+IC0J
aWYgKGF0b21pY19yZWFkKCZ2YmxhbmstPnJlZmNvdW50KSA9PSAwICYmIHZibGFuay0+ZW5hYmxl
ZCkgewo+ICsJaWYgKGF0b21pY19yZWFkKCZ2YmxhbmstPnJlZmNvdW50KSA9PSAwICYmIFJFQURf
T05DRSh2YmxhbmstPmVuYWJsZWQpKSB7CgpIbW0uIEFyZW4ndCBtb3N0IG9mIHRoZXNlIGFjY2Vz
c2VzIGluc2lkZSB0aGUgbG9jaz8gTG9va3MgbGlrZSB5b3UncmUKbWFya2luZyBldmVyeXRoaW5n
IFJFQUQvV1JJVEVfT05DRSgpPwoKPiAgCQlEUk1fREVCVUcoImRpc2FibGluZyB2Ymxhbmsgb24g
Y3J0YyAldVxuIiwgcGlwZSk7Cj4gIAkJdmJsYW5rX2Rpc2FibGVfYW5kX3NhdmUoZGV2LCBwaXBl
KTsKPiAgCX0KPiBAQCAtMzg0LDcgKzM4Miw3IEBAIHZvaWQgZHJtX3ZibGFua19jbGVhbnVwKHN0
cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAlmb3IgKHBpcGUgPSAwOyBwaXBlIDwgZGV2LT5udW1f
Y3J0Y3M7IHBpcGUrKykgewo+ICAJCXN0cnVjdCBkcm1fdmJsYW5rX2NydGMgKnZibGFuayA9ICZk
ZXYtPnZibGFua1twaXBlXTsKPiAgCj4gLQkJV0FSTl9PTih2YmxhbmstPmVuYWJsZWQgJiYKPiAr
CQlXQVJOX09OKFJFQURfT05DRSh2YmxhbmstPmVuYWJsZWQpICYmCj4gIAkJCWRybV9jb3JlX2No
ZWNrX2ZlYXR1cmUoZGV2LCBEUklWRVJfTU9ERVNFVCkpOwo+ICAKPiAgCQlkZWxfdGltZXJfc3lu
YygmdmJsYW5rLT5kaXNhYmxlX3RpbWVyKTsKPiBAQCAtNTY0LDcgKzU2Miw3IEBAIGludCBkcm1f
aXJxX3VuaW5zdGFsbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJCWZvciAoaSA9IDA7IGkg
PCBkZXYtPm51bV9jcnRjczsgaSsrKSB7Cj4gIAkJCXN0cnVjdCBkcm1fdmJsYW5rX2NydGMgKnZi
bGFuayA9ICZkZXYtPnZibGFua1tpXTsKPiAgCj4gLQkJCWlmICghdmJsYW5rLT5lbmFibGVkKQo+
ICsJCQlpZiAoIVJFQURfT05DRSh2YmxhbmstPmVuYWJsZWQpKQo+ICAJCQkJY29udGludWU7Cj4g
IAo+ICAJCQlXQVJOX09OKGRybV9jb3JlX2NoZWNrX2ZlYXR1cmUoZGV2LCBEUklWRVJfTU9ERVNF
VCkpOwo+IEBAIC0xMTA1LDExICsxMTAzLDE2IEBAIHN0YXRpYyBpbnQgZHJtX3ZibGFua19lbmFi
bGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IHBpcGUpCj4gIAkJICovCj4g
IAkJcmV0ID0gX19lbmFibGVfdmJsYW5rKGRldiwgcGlwZSk7Cj4gIAkJRFJNX0RFQlVHKCJlbmFi
bGluZyB2Ymxhbmsgb24gY3J0YyAldSwgcmV0OiAlZFxuIiwgcGlwZSwgcmV0KTsKPiAtCQlpZiAo
cmV0KQo+ICsJCWlmIChyZXQpIHsKPiAgCQkJYXRvbWljX2RlYygmdmJsYW5rLT5yZWZjb3VudCk7
Cj4gLQkJZWxzZSB7Cj4gLQkJCXZibGFuay0+ZW5hYmxlZCA9IHRydWU7Cj4gKwkJfSBlbHNlIHsK
PiAgCQkJZHJtX3VwZGF0ZV92YmxhbmtfY291bnQoZGV2LCBwaXBlLCAwKTsKPiArCQkJLyogZHJt
X3VwZGF0ZV92YmxhbmtfY291bnQoKSBpbmNsdWRlcyBhIHdtYiBzbyB3ZSBqdXN0Cj4gKwkJCSAq
IG5lZWQgdG8gZW5zdXJlIHRoYXQgdGhlIGNvbXBpbGVyIGVtaXRzIHRoZSB3cml0ZQo+ICsJCQkg
KiB0byBtYXJrIHRoZSB2YmxhbmsgYXMgZW5hYmxlZCBhZnRlciB0aGUgY2FsbAo+ICsJCQkgKiB0
byBkcm1fdXBkYXRlX3ZibGFua19jb3VudCgpLgo+ICsJCQkgKi8KPiArCQkJV1JJVEVfT05DRSh2
YmxhbmstPmVuYWJsZWQsIHRydWUpOwoKT3JkZXJpbmcrYmFycmllciBsb29rcyBjb3JyZWN0IHRv
IG1lLgoKPiAgCQl9Cj4gIAl9Cj4gIAo+IEBAIC0xMTQ4LDcgKzExNTEsNyBAQCBzdGF0aWMgaW50
IGRybV92YmxhbmtfZ2V0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBl
KQo+ICAJaWYgKGF0b21pY19hZGRfcmV0dXJuKDEsICZ2YmxhbmstPnJlZmNvdW50KSA9PSAxKSB7
Cj4gIAkJcmV0ID0gZHJtX3ZibGFua19lbmFibGUoZGV2LCBwaXBlKTsKPiAgCX0gZWxzZSB7Cj4g
LQkJaWYgKCF2YmxhbmstPmVuYWJsZWQpIHsKPiArCQlpZiAoIVJFQURfT05DRSh2YmxhbmstPmVu
YWJsZWQpKSB7Cj4gIAkJCWF0b21pY19kZWMoJnZibGFuay0+cmVmY291bnQpOwo+ICAJCQlyZXQg
PSAtRUlOVkFMOwo+ICAJCX0KPiBAQCAtMTUxNyw3ICsxNTIwLDcgQEAgc3RhdGljIGludCBkcm1f
cXVldWVfdmJsYW5rX2V2ZW50KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBw
aXBlLAo+ICAJICogdmJsYW5rIGRpc2FibGUsIHNvIG5vIG5lZWQgZm9yIGZ1cnRoZXIgbG9ja2lu
Zy4gIFRoZSByZWZlcmVuY2UgZnJvbQo+ICAJICogZHJtX3ZibGFua19nZXQoKSBwcm90ZWN0cyBh
Z2FpbnN0IHZibGFuayBkaXNhYmxlIGZyb20gYW5vdGhlciBzb3VyY2UuCj4gIAkgKi8KPiAtCWlm
ICghdmJsYW5rLT5lbmFibGVkKSB7Cj4gKwlpZiAoIVJFQURfT05DRSh2YmxhbmstPmVuYWJsZWQp
KSB7Cj4gIAkJcmV0ID0gLUVJTlZBTDsKPiAgCQlnb3RvIGVycl91bmxvY2s7Cj4gIAl9Cj4gQEAg
LTE2NDQsNyArMTY0Nyw3IEBAIGludCBkcm1fd2FpdF92Ymxhbmsoc3RydWN0IGRybV9kZXZpY2Ug
KmRldiwgdm9pZCAqZGF0YSwKPiAgCQlEUk1fV0FJVF9PTihyZXQsIHZibGFuay0+cXVldWUsIDMg
KiBIWiwKPiAgCQkJICAgICgoKGRybV92YmxhbmtfY291bnQoZGV2LCBwaXBlKSAtCj4gIAkJCSAg
ICAgICB2Ymx3YWl0LT5yZXF1ZXN0LnNlcXVlbmNlKSA8PSAoMSA8PCAyMykpIHx8Cj4gLQkJCSAg
ICAgIXZibGFuay0+ZW5hYmxlZCB8fAo+ICsJCQkgICAgICFSRUFEX09OQ0UodmJsYW5rLT5lbmFi
bGVkKSB8fAo+ICAJCQkgICAgICFkZXYtPmlycV9lbmFibGVkKSk7Cj4gIAl9Cj4gIAo+IEBAIC0x
NzE0LDYgKzE3MTcsOSBAQCBib29sIGRybV9oYW5kbGVfdmJsYW5rKHN0cnVjdCBkcm1fZGV2aWNl
ICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKQo+ICAJaWYgKFdBUk5fT04ocGlwZSA+PSBkZXYtPm51
bV9jcnRjcykpCj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAKPiArCWlmICghUkVBRF9PTkNFKHZibGFu
ay0+ZW5hYmxlZCkpCj4gKwkJcmV0dXJuIGZhbHNlOwoKVGhpcyB0byBtZSBsb29rcyBsaWtlIGl0
IGNvdWxkIHRoZW9yZXRpY2FsbHkgY2F1c2UgdXMgdG8KbWlzcyBhbiBpbnRlcnJ1cHQuCgoxLiBl
bmFibGVfaXJxKCkKMi4gZHJtX3VwZGF0ZV92YmxhbmtfY291bnQoKQozLiBpcnEgZmlyZXMKNC4g
ZHJtX2hhbmRsZV92YmxhbmsoKSBkb2Vzbid0IGRvIGFueXRoaW5nCjUuIGVuYWJsZWQ9dHJ1ZQoK
PiArCj4gIAlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2LT5ldmVudF9sb2NrLCBpcnFmbGFncyk7Cj4g
IAo+ICAJLyogTmVlZCB0aW1lc3RhbXAgbG9jayB0byBwcmV2ZW50IGNvbmN1cnJlbnQgZXhlY3V0
aW9uIHdpdGgKPiAtLSAKPiAyLjExLjAKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt
YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz
LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=