From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm: Mark up accesses of vblank->enabled outside of its spinlock Date: Fri, 17 Mar 2017 13:25:32 +0200 Message-ID: <20170317112532.GS31595@intel.com> References: <20170316234749.1297-1-chris@chris-wilson.co.uk> <20170317094751.GL31595@intel.com> <20170317101951.GO2118@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170317101951.GO2118@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXIgMTcsIDIwMTcgYXQgMTA6MTk6NTFBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIEZyaSwgTWFyIDE3LCAyMDE3IGF0IDExOjQ3OjUxQU0gKzAyMDAsIFZpbGxlIFN5 cmrDpGzDpCB3cm90ZToKPiA+IE9uIFRodSwgTWFyIDE2LCAyMDE3IGF0IDExOjQ3OjQ4UE0gKzAw MDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+ID4gQEAgLTM2MCw3ICszNTgsNyBAQCBzdGF0aWMg dm9pZCB2YmxhbmtfZGlzYWJsZV9mbih1bnNpZ25lZCBsb25nIGFyZykKPiA+ID4gIAl1bnNpZ25l ZCBsb25nIGlycWZsYWdzOwo+ID4gPiAgCj4gPiA+ICAJc3Bpbl9sb2NrX2lycXNhdmUoJmRldi0+ dmJsX2xvY2ssIGlycWZsYWdzKTsKPiA+ID4gLQlpZiAoYXRvbWljX3JlYWQoJnZibGFuay0+cmVm Y291bnQpID09IDAgJiYgdmJsYW5rLT5lbmFibGVkKSB7Cj4gPiA+ICsJaWYgKGF0b21pY19yZWFk KCZ2YmxhbmstPnJlZmNvdW50KSA9PSAwICYmIFJFQURfT05DRSh2YmxhbmstPmVuYWJsZWQpKSB7 Cj4gPiAKPiA+IEhtbS4gQXJlbid0IG1vc3Qgb2YgdGhlc2UgYWNjZXNzZXMgaW5zaWRlIHRoZSBs b2NrPyBMb29rcyBsaWtlIHlvdSdyZQo+ID4gbWFya2luZyBldmVyeXRoaW5nIFJFQUQvV1JJVEVf T05DRSgpPwo+IAo+IFRoZXJlJ3MgbGlrZSAzIGRpZmZlcmVudCBsb2NrcyBoZXJlLiBBZmFpY3Qs IHRoZSBjb3JyZWN0IG9uZSBmb3IKPiBzZXJpYWxpc2luZyB2YmxhbmstPmVuYWJsZWQgd2FzIGRl di0+dmJsYW5rX3RpbWVfbG9jay4gRXZlcnkgYWNjZXNzCj4gb3V0c2lkZSBvZiB0aGF0IGxvY2ss IEkgbWFya2VkIHVwIGFzIFJFQURfT05DRS4KPiAKPiBPaCwgeW91IGFyZSB1c2luZyB2YmxfbG9j ayBhcyB0aGUgYmFycmllcj8gVGhhdCdzIG5vdCBhcyBjbGVhciBmb3IKPiBkaXNhYmxlOgo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jIGIvZHJpdmVycy9ncHUvZHJt L2RybV9pcnEuYwo+IGluZGV4IDUzYTUyNmM3YjI0ZC4uZjQ0N2VkMDdlZjk1IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2lycS5jCj4gQEAgLTMyNSw2ICszMjUsOCBAQCBzdGF0aWMgdm9pZCB2YmxhbmtfZGlzYWJsZV9h bmRfc2F2ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPiAgICAg ICAgIHN0cnVjdCBkcm1fdmJsYW5rX2NydGMgKnZibGFuayA9ICZkZXYtPnZibGFua1twaXBlXTsK PiAgICAgICAgIHVuc2lnbmVkIGxvbmcgaXJxZmxhZ3M7Cj4gIAo+ICsgICAgICAgYXNzZXJ0X3Nw aW5fbG9ja2VkKCZkZXYtPnZibF9sb2NrKTsKPiArCj4gICAgICAgICAvKiBQcmV2ZW50IHZibGFu ayBpcnEgcHJvY2Vzc2luZyB3aGlsZSBkaXNhYmxpbmcgdmJsYW5rIGlycXMsCj4gICAgICAgICAg KiBzbyBubyB1cGRhdGVzIG9mIHRpbWVzdGFtcHMgb3IgY291bnQgY2FuIGhhcHBlbiBhZnRlciB3 ZSd2ZQo+ICAgICAgICAgICogZGlzYWJsZWQuIE5lZWRlZCB0byBwcmV2ZW50IHJhY2VzIGluIGNh c2Ugb2YgZGVsYXllZCBpcnEncy4KPiAKPiAKPiA+ID4gQEAgLTE3MTQsNiArMTcxNyw5IEBAIGJv b2wgZHJtX2hhbmRsZV92Ymxhbmsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50 IHBpcGUpCj4gPiA+ICAJaWYgKFdBUk5fT04ocGlwZSA+PSBkZXYtPm51bV9jcnRjcykpCj4gPiA+ ICAJCXJldHVybiBmYWxzZTsKPiA+ID4gIAo+ID4gPiArCWlmICghUkVBRF9PTkNFKHZibGFuay0+ ZW5hYmxlZCkpCj4gPiA+ICsJCXJldHVybiBmYWxzZTsKPiA+IAo+ID4gVGhpcyB0byBtZSBsb29r cyBsaWtlIGl0IGNvdWxkIHRoZW9yZXRpY2FsbHkgY2F1c2UgdXMgdG8KPiA+IG1pc3MgYW4gaW50 ZXJydXB0Lgo+ID4gCj4gPiAxLiBlbmFibGVfaXJxKCkKPiA+IDIuIGRybV91cGRhdGVfdmJsYW5r X2NvdW50KCkKPiA+IDMuIGlycSBmaXJlcwo+ID4gNC4gZHJtX2hhbmRsZV92YmxhbmsoKSBkb2Vz bid0IGRvIGFueXRoaW5nCj4gPiA1LiBlbmFibGVkPXRydWUKPiAKPiBTdXJlLiBUaGVyZSdzIGEg ZGFuZ2VyIHlvdSBtaXNzIHRoZSBpcnEgYW55d2F5LCBhbmQgc28gdGhlIGxhc3QgYWN0aW9uCj4g YWZ0ZXIgZW5hYmxpbmcgdGhlIGludGVycnVwdCBzaG91bGQgYmUgdG8gcHJvY2VzcyBhbnkgY29t cGxldGVkIGV2ZW50cyAtCj4gdGhhdCdzIGltcGxpY2l0bHkgaGFuZGxlZCBieSBlbmFibGluZyB0 aGUgaW50ZXJydXB0IGluIGFkdmFuY2Ugb2YgYWRkaW5nCj4gdGhlIGZpcnN0IGV2ZW50LiBJbiB0 aGUgc2NlbmFyaW8gYWJvdmUsIHRoZXJlIHNob3VsZCBiZSBub3RoaW5nIHRvIGRvLgoKVGhhdCdz IGEgc2xpZ2h0bHkgZGlmZmVyZW50IHNjZW5hcmlvIHNpbmNlIHlvdSdyZSBvbmx5IHRoaW5raW5n IGFib3V0IAphY3R1YWxseSBlbmFibGluZyB0aGUgaW50ZXJydXB0IHZzLiBjYWxsaW5nIGRybV91 cGRhdGVfdmJsYW5rX2NvdW50KCkuClRoYXQgaXMgZmluZSBhcyBpcy4gQnV0IHdpdGggdGhlIGV4 dHJhICdlbmFibGVkJyBjaGVjayBpbiB0aGUgaW50ZXJydXB0CmhhbmRsZXIgeW91J3JlIGVmZmVj dGl2ZWx5IHJldmVyc2luZyB0aGF0IG9yZGVyIHRvIGVuYWJsZSB0aGUgaW50ZXJydXB0CmFmdGVy IGRybV91cGRhdGVfdmJsYW5rX2NvdW50KCkuIEhlbmNlIHdlIGNhbiBsb3NlIGFuIGludGVycnVw dCBub3cuCgpPZiBjb3Vyc2Ugd2Ugd291bGQgZXZlbnR1YWxseSBnZXQgYW5vdGhlciBpbnRlcnJ1 cHQsIGFuZCB0aGFua3MgdG8gdGhlCmh3IGZyYW1lIGNvdW50ZXIgYW5kIHdoYXRub3Qgd2Ugd291 bGRuJ3QgYWN0dWFsbHkgbG9zZSBvdXIgcGxhY2UgZW50aXJlbHksCmJ1dCB3ZSB3b3VsZCBzZWUg dGhlIGNvdW50ZXIganVtcCBieSB0d28gZnJhbWVzIHdoZW4gd2UgYWN0dWFsbHkgaGFuZGxlCnRo ZSBpbnRlcnJ1cHQuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK