From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1copsA-0005PJ-BX for qemu-devel@nongnu.org; Fri, 17 Mar 2017 07:16:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cops7-0003r6-MO for qemu-devel@nongnu.org; Fri, 17 Mar 2017 07:16:42 -0400 Received: from 8.mo69.mail-out.ovh.net ([46.105.56.233]:37527) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cops7-0003qW-FF for qemu-devel@nongnu.org; Fri, 17 Mar 2017 07:16:39 -0400 Received: from player738.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo69.mail-out.ovh.net (Postfix) with ESMTP id 3D8911BAEB for ; Fri, 17 Mar 2017 12:16:38 +0100 (CET) Date: Fri, 17 Mar 2017 12:16:30 +0100 From: Greg Kurz Message-ID: <20170317121630.503719ec@bahia.lab.toulouse-stg.fr.ibm.com> In-Reply-To: <1489694518-16978-3-git-send-email-sstabellini@kernel.org> References: <1489694518-16978-1-git-send-email-sstabellini@kernel.org> <1489694518-16978-3-git-send-email-sstabellini@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_//m_V3EkTwWpOrSsbmFvHM30"; protocol="application/pgp-signature" Subject: Re: [Qemu-devel] [PATCH v3 3/9] 9p: introduce a type for the 9p header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, jgross@suse.com, Stefano Stabellini , anthony.perard@citrix.com, "Aneesh Kumar K.V" --Sig_//m_V3EkTwWpOrSsbmFvHM30 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 16 Mar 2017 13:01:52 -0700 Stefano Stabellini wrote: > Use the new type in virtio-9p-device. >=20 > Signed-off-by: Stefano Stabellini > CC: anthony.perard@citrix.com > CC: jgross@suse.com > CC: Aneesh Kumar K.V > CC: Greg Kurz > --- Reviewed-by: Greg Kurz > hw/9pfs/9p.h | 6 ++++++ > hw/9pfs/virtio-9p-device.c | 6 +----- > 2 files changed, 7 insertions(+), 5 deletions(-) >=20 > diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h > index b7e8362..5312d8a 100644 > --- a/hw/9pfs/9p.h > +++ b/hw/9pfs/9p.h > @@ -119,6 +119,12 @@ static inline char *rpath(FsContext *ctx, const char= *path) > typedef struct V9fsPDU V9fsPDU; > struct V9fsState; > =20 > +typedef struct { > + uint32_t size_le; > + uint8_t id; > + uint16_t tag_le; > +} QEMU_PACKED P9MsgHeader; > + > struct V9fsPDU > { > uint32_t size; > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c > index 27a4a32..3782f43 100644 > --- a/hw/9pfs/virtio-9p-device.c > +++ b/hw/9pfs/virtio-9p-device.c > @@ -46,11 +46,7 @@ static void handle_9p_output(VirtIODevice *vdev, VirtQ= ueue *vq) > VirtQueueElement *elem; > =20 > while ((pdu =3D pdu_alloc(s))) { > - struct { > - uint32_t size_le; > - uint8_t id; > - uint16_t tag_le; > - } QEMU_PACKED out; > + P9MsgHeader out; > =20 > elem =3D virtqueue_pop(vq, sizeof(VirtQueueElement)); > if (!elem) { --Sig_//m_V3EkTwWpOrSsbmFvHM30 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAljLxY4ACgkQAvw66wEB28KyPgCdHpLkKdwftqamgtzuP7g+N0RZ n30AoKE9+Xev+r4X8sMqEpVeJsZYg21e =6QYN -----END PGP SIGNATURE----- --Sig_//m_V3EkTwWpOrSsbmFvHM30-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kurz Subject: Re: [PATCH v3 3/9] 9p: introduce a type for the 9p header Date: Fri, 17 Mar 2017 12:16:30 +0100 Message-ID: <20170317121630.503719ec@bahia.lab.toulouse-stg.fr.ibm.com> References: <1489694518-16978-1-git-send-email-sstabellini@kernel.org> <1489694518-16978-3-git-send-email-sstabellini@kernel.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4446387917849231365==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cops7-0000tH-MI for xen-devel@lists.xenproject.org; Fri, 17 Mar 2017 11:16:39 +0000 Received: from player738.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo69.mail-out.ovh.net (Postfix) with ESMTP id 3E6D51BCB0 for ; Fri, 17 Mar 2017 12:16:38 +0100 (CET) In-Reply-To: <1489694518-16978-3-git-send-email-sstabellini@kernel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Stefano Stabellini Cc: jgross@suse.com, qemu-devel@nongnu.org, Stefano Stabellini , "Aneesh Kumar K.V" , anthony.perard@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org --===============4446387917849231365== Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_//m_V3EkTwWpOrSsbmFvHM30"; protocol="application/pgp-signature" --Sig_//m_V3EkTwWpOrSsbmFvHM30 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 16 Mar 2017 13:01:52 -0700 Stefano Stabellini wrote: > Use the new type in virtio-9p-device. >=20 > Signed-off-by: Stefano Stabellini > CC: anthony.perard@citrix.com > CC: jgross@suse.com > CC: Aneesh Kumar K.V > CC: Greg Kurz > --- Reviewed-by: Greg Kurz > hw/9pfs/9p.h | 6 ++++++ > hw/9pfs/virtio-9p-device.c | 6 +----- > 2 files changed, 7 insertions(+), 5 deletions(-) >=20 > diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h > index b7e8362..5312d8a 100644 > --- a/hw/9pfs/9p.h > +++ b/hw/9pfs/9p.h > @@ -119,6 +119,12 @@ static inline char *rpath(FsContext *ctx, const char= *path) > typedef struct V9fsPDU V9fsPDU; > struct V9fsState; > =20 > +typedef struct { > + uint32_t size_le; > + uint8_t id; > + uint16_t tag_le; > +} QEMU_PACKED P9MsgHeader; > + > struct V9fsPDU > { > uint32_t size; > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c > index 27a4a32..3782f43 100644 > --- a/hw/9pfs/virtio-9p-device.c > +++ b/hw/9pfs/virtio-9p-device.c > @@ -46,11 +46,7 @@ static void handle_9p_output(VirtIODevice *vdev, VirtQ= ueue *vq) > VirtQueueElement *elem; > =20 > while ((pdu =3D pdu_alloc(s))) { > - struct { > - uint32_t size_le; > - uint8_t id; > - uint16_t tag_le; > - } QEMU_PACKED out; > + P9MsgHeader out; > =20 > elem =3D virtqueue_pop(vq, sizeof(VirtQueueElement)); > if (!elem) { --Sig_//m_V3EkTwWpOrSsbmFvHM30 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAljLxY4ACgkQAvw66wEB28KyPgCdHpLkKdwftqamgtzuP7g+N0RZ n30AoKE9+Xev+r4X8sMqEpVeJsZYg21e =6QYN -----END PGP SIGNATURE----- --Sig_//m_V3EkTwWpOrSsbmFvHM30-- --===============4446387917849231365== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============4446387917849231365==--