From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, drjones@redhat.com,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.9 v2] virtio: Fix error handling in virtio_bus_device_plugged
Date: Fri, 17 Mar 2017 13:39:52 +0100 [thread overview]
Message-ID: <20170317133952.1d5bfcce.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20170317123242.32579-1-famz@redhat.com>
On Fri, 17 Mar 2017 20:32:42 +0800
Fam Zheng <famz@redhat.com> wrote:
> For one thing we shouldn't continue if an error happened, for the other
> two steps failing can cause an abort() in error_setg because we reuse
> the same errp blindly.
>
> Add error handling checks to fix both issues.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
>
> v2: Don't forget the last errp -> &local_err. [Drew]
> ---
> hw/virtio/virtio-bus.c | 20 +++++++++++++++++---
> 1 file changed, 17 insertions(+), 3 deletions(-)
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2017-03-17 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 12:32 [Qemu-devel] [PATCH for-2.9 v2] virtio: Fix error handling in virtio_bus_device_plugged Fam Zheng
2017-03-17 12:39 ` Cornelia Huck [this message]
2017-03-17 12:42 ` Andrew Jones
2017-03-17 18:23 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317133952.1d5bfcce.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=drjones@redhat.com \
--cc=famz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.