From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail.free-electrons.com (mail.free-electrons.com. [62.4.15.54]) by gmr-mx.google.com with ESMTP id n128si159284wmf.2.2017.03.17.08.05.25 for ; Fri, 17 Mar 2017 08:05:25 -0700 (PDT) Date: Fri, 17 Mar 2017 16:05:24 +0100 From: Alexandre Belloni To: Geert Uytterhoeven Cc: Chris Brandt , Alessandro Zummo , Rob Herring , Mark Rutland , Simon Horman , RTCLINUX , "devicetree@vger.kernel.org" , Linux-Renesas Subject: [rtc-linux] Re: [PATCH 2/5] rtc: Add rtc-sh Message-ID: <20170317150524.oijto6gtjxycdnwn@piout.net> References: <20170316175112.27913-1-chris.brandt@renesas.com> <20170316175112.27913-3-chris.brandt@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi, On 17/03/2017 at 14:55:48 +0100, Geert Uytterhoeven wrote: > >> it would still be good to have phandles to the external clock sources as > >> well, as that describes the hardware topology. > > > > I'm confused, you mean make new clocks node for RTC_X1 (fixed at 32.768kHZ) and > > RTC_X3 (fixed at 4MHz), but then not really do anything with then? (the driver > > You still do something with them, as they'll be linked from the rtc device node. > > > doesn't need them) > > The driver may use them in the future. > E.g. to select among X1, X3, or EXTAL, depending on availability. > I'm on Geert's side here, I wouldn't rely on the bootloader to set everything up correctly. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 2/5] rtc: Add rtc-sh Date: Fri, 17 Mar 2017 16:05:24 +0100 Message-ID: <20170317150524.oijto6gtjxycdnwn@piout.net> References: <20170316175112.27913-1-chris.brandt@renesas.com> <20170316175112.27913-3-chris.brandt@renesas.com> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Geert Uytterhoeven Cc: Chris Brandt , Alessandro Zummo , Rob Herring , Mark Rutland , Simon Horman , RTCLINUX , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux-Renesas List-Id: devicetree@vger.kernel.org Hi, On 17/03/2017 at 14:55:48 +0100, Geert Uytterhoeven wrote: > >> it would still be good to have phandles to the external clock sources as > >> well, as that describes the hardware topology. > > > > I'm confused, you mean make new clocks node for RTC_X1 (fixed at 32.768kHZ) and > > RTC_X3 (fixed at 4MHz), but then not really do anything with then? (the driver > > You still do something with them, as they'll be linked from the rtc device node. > > > doesn't need them) > > The driver may use them in the future. > E.g. to select among X1, X3, or EXTAL, depending on availability. > I'm on Geert's side here, I wouldn't rely on the bootloader to set everything up correctly. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com ([62.4.15.54]:59120 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbdCQPGG (ORCPT ); Fri, 17 Mar 2017 11:06:06 -0400 Date: Fri, 17 Mar 2017 16:05:24 +0100 From: Alexandre Belloni To: Geert Uytterhoeven Cc: Chris Brandt , Alessandro Zummo , Rob Herring , Mark Rutland , Simon Horman , RTCLINUX , "devicetree@vger.kernel.org" , Linux-Renesas Subject: Re: [PATCH 2/5] rtc: Add rtc-sh Message-ID: <20170317150524.oijto6gtjxycdnwn@piout.net> References: <20170316175112.27913-1-chris.brandt@renesas.com> <20170316175112.27913-3-chris.brandt@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi, On 17/03/2017 at 14:55:48 +0100, Geert Uytterhoeven wrote: > >> it would still be good to have phandles to the external clock sources as > >> well, as that describes the hardware topology. > > > > I'm confused, you mean make new clocks node for RTC_X1 (fixed at 32.768kHZ) and > > RTC_X3 (fixed at 4MHz), but then not really do anything with then? (the driver > > You still do something with them, as they'll be linked from the rtc device node. > > > doesn't need them) > > The driver may use them in the future. > E.g. to select among X1, X3, or EXTAL, depending on availability. > I'm on Geert's side here, I wouldn't rely on the bootloader to set everything up correctly. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com